RoutingResources Controller Refactor with Integration Testing for OpenTSDB #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zack-rma
added this to the F0215 Task 2.2 - OpenTSDB: Integration Testing Controllers milestone
|
Requires OpenDCS Toolkit modifications found in this PR: opendcs/opendcs#909 |
rma-rripken
approved these changes
Jan 14, 2025
6 tasks
zack-rma
changed the title
This was
linked to
issues
Jan 31, 2025
6 tasks
…OpenDCS Toolkit methods
zack-rma
force-pushed
the
feature/task_cwms_support_routing_resources_it
branch
from
513a950 to
88ba624
Compare
|
Build failure from sonar task |
Draft
6 tasks
adamkorynta
requested changes
Feb 24, 2025
| boolean backLogValid = false; | ||
| Long dacqEventId = null; | ||
| Long timeInMillis = null; | ||
| if (backlog != null && !backlog.trim().isEmpty()) |
There was a problem hiding this comment.
extract to its own method
| DatabaseIO dbIo = null; | ||
| try | ||
| { | ||
| dbIo = getLegacyDatabase(); |
There was a problem hiding this comment.
move this call out of the try/catch (make sure to update all methods like this)
| } | ||
| } | ||
|
|
||
| public static void storeDacqEvent(DacqEvent event) throws DatabaseException |
There was a problem hiding this comment.
These methods are reused between multiple tests?
|
Superseded by: #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #243 .
Solution
Implements integration testing on refactored controller against OpenTSDB.
how you tested the change
Includes integration tests. Some testing still in progress.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.