Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LRGS endpoints #352

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

adamkorynta
Copy link
Contributor

@adamkorynta adamkorynta commented Feb 19, 2025

Problem Description

Fixes #340 and #341

LRGS endpoints require lots of server-side state that is better suited for a separate web application that is separate from an application that serves data.

Solution

Remove the LRGS endpoints and accompanying classes.

how you tested the change

Testing via automated integration testing.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

Eliminated obsolete classes and methods from the codebase related to API event handling, data sources, and LRGS status.
@adamkorynta adamkorynta marked this pull request as draft February 19, 2025 22:21
@adamkorynta adamkorynta marked this pull request as ready for review February 19, 2025 23:52
This was linked to issues Feb 19, 2025
Copy link
Collaborator

@zack-rma zack-rma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the ApiAppDao changes might break some tests until #311 is updated and merged in, but I could be wrong.

@adamkorynta adamkorynta merged commit 289ddfe into feature/task_cwms_support Feb 20, 2025
3 checks passed
@adamkorynta adamkorynta deleted the feature/remove_lrgs_endpoint branch February 20, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insecure AppResources endpoints Remove LRGS Endpoint
2 participants