-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CWMS integration testing coverage to the AppResources controller #354
Draft
zack-rma
wants to merge
17
commits into
opendcs:feature/task_cwms_support
Choose a base branch
from
zack-rma:feature/cwms_app
base: feature/task_cwms_support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add CWMS integration testing coverage to the AppResources controller #354
zack-rma
wants to merge
17
commits into
opendcs:feature/task_cwms_support
from
zack-rma:feature/cwms_app
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #293.
Based on changes found here: #311. Will require rebase when those changes are merged.
Requires Toolkit changes found here: opendcs/opendcs#930.
Solution
Moved test data to
DEFAULT
directory, updated object mapping, removedstart
,stop
andevents
endpoints and associated tests.how you tested the change
Integration tested against CWMS and OpenTSDB database instances.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.