Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Special case single star branch/tag constraint #745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelsauter
Copy link
Member

@michaelsauter michaelsauter commented Nov 17, 2023

If the constraint is e.g. branches: ["*"], then all branch names are matched, even ones containing slashes. Before this change, e.g. feature/foo would not have matched.

Closes #691.

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

If the constraint is e.g. `branches: ["*"]`, then all branch names are
matched, even ones containing slashes. Before this change, e.g.
`feature/foo` would not have matched.
@henninggross
Copy link
Member

I believe the docs of the configuration need to be updated as well. I am on my phone sadly and cannot link to the specific lines, but there is a place where it is mentioned that "*" does not catch every branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger * pattern only matches non-slash characters
2 participants