Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that it runs out of the box #191

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reenable
  • Loading branch information
mccalluc committed Nov 26, 2024
commit aac891d6e999cb2dcc7ebf7e072f9bb47b855f8c
6 changes: 2 additions & 4 deletions tests/test_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,14 @@ def expect_no_error():
page.get_by_label("Upper").fill(new_value)
# Uncheck the column:
page.get_by_label("grade").uncheck()
# TODO: flaky?
# expect_not_visible(simulation)
expect_not_visible(simulation)
# Recheck the column:
page.get_by_label("grade").check()
expect_visible(simulation)
assert page.get_by_label("Upper").input_value() == new_value
# Add a second column:
page.get_by_label("blank").check()
# TODO: flaky?
# expect(page.get_by_text("Weight")).to_have_count(2)
expect(page.get_by_text("Weight")).to_have_count(2)
# TODO: Setting more inputs without checking for updates
# causes recalculations to pile up, and these cause timeouts on CI:
# It is still rerendering the graph after hitting "Download results".
Expand Down