Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document dependencies in generated code #207

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Document dependencies in generated code #207

merged 2 commits into from
Jan 7, 2025

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Dec 19, 2024 •
edited
Loading

Having a separate requirements.txt with the script feels like overkill.

We also don't have a test that confirms that the given dependencies are sufficient, but that also feels like overkill.

ekraffmiller
ekraffmiller approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approving

@mccalluc mccalluc merged commit a63a215 into main Jan 7, 2025
2 checks passed
@mccalluc mccalluc deleted the 166-document-installs branch January 7, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekraffmiller ekraffmiller ekraffmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DP Wizard
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With downloaded code, describe the necessary pip installs
2 participants
@mccalluc @ekraffmiller