Skip to content

Commit

Permalink
added todo's for #11
Browse files Browse the repository at this point in the history
  • Loading branch information
rhutten committed Oct 28, 2020
1 parent 70001b4 commit a0bcb0d
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 9 deletions.
28 changes: 20 additions & 8 deletions examples/test_osm.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,26 @@
print(type(osm))

# TODO: read branches, culvert, cross sections and properties from file and plot network to check

# TODO: snapping of open drains over culverts. May not be needed as wel only use parameterized profiles

# TODO: make culvert points (midpoint) with properties

# TODO assign elevation value to cross sections. this needs to be retrieved from a DEM (which we have!)

# TODO: where cross sections are meeting a culvert, it may make sense to straighten the elevation value up and downstream of culvert
# TODO: BRANCHES - read id column from json. Do not deviate between drain type
# TODO: BRANCHES - connect branches on the right locations
# TODO: plot branches

# TODO: CROSS SECTIONS DEFINTION - read id, drain_type, material, width, depth, top_width, diameter, profile_op, profile_cl, bottom_width columns from json
# TODO: CROSS SECTIONS DEFINTION - specify roughness dependent on material add this
# TODO: CROSS SECTION DEFINITION - assign elevation value to cross sections. this needs to be retrieved from a DEM (which we have!)
# TODO: CROSS SECTION DEFINITION - create circular profiles --> prof_idofbranch
# TODO: CROSS SECTION DEFINITION - create rectangular profiles --> prof_idofbranch
# TODO: CROSS SECTION DEFINITION - create trapezoid profiles --> prof_idofbranch
# TODO: CROSS SECTION LOCATION - select rows with drain type other than culvert
# TODO: CROSS SECTION LOCATION - add cross sections at start and end of branch. Take the longitudinal slope with SHIFT parameter into account
# TODO: plot branches + cross sections locations

# TODO: STRUCTURE - read id, draintype
# TODO: STRUCTURE - select rows with draintype culvert
# TODO: STRUCTURE - determine length and midpoint location culvert
# TODO: STRUCTURE - snapping of open drains over culverts. May not be needed as wel only use parameterized profiles
# TODO: STRUCTURE - where cross sections are meeting a culvert, it may make sense to straighten the elevation value up and downstream of culvert
# TODO: plot branches + cross sections locations + structures

# TODO: create DFM parsers for drains, culverts and cross sections based on dfmmodel.structures.io.xxxx_from_hydamo as example

Expand Down
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
test_suite="tests",
use_scm_version=True,
setup_requires=["setuptools_scm"],
python_requires=">=3.6",
python_requires=">=3.7",
install_requires=[
"gdal",
"geopandas",
Expand All @@ -34,6 +34,7 @@
"rasterio",
"rasterstats",
"scipy",
"setuptools",
"setuptools_scm",
"tqdm"
],
Expand Down

0 comments on commit a0bcb0d

Please sign in to comment.