Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zfs): timer stop when checkVolCreation exit #600

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rfyiamcool
Copy link

Pull Request template

Why is this PR required? What issue does it fix?:

when func is end, we need to stop timer.

What this PR does?:

when func is end, we need to stop timer.

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/website is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

The PR title message must follow convention:
<type>(<scope>): <subject>.

Where:

  • type is defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md.
    Most common types are:

    • feat - for new features, not a new feature for build script
    • fix - for bug fixes or improvements, not a fix for build script
    • chore - changes not related to production code
    • docs - changes related to documentation
    • style - formatting, missing semi colons, linting fix etc; no significant production code changes
    • test - adding missing tests, refactoring tests; no production code change
    • refactor - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
  • scope is a single word that best describes where the changes fit.
    Most common scopes are like:

    • data engine (localpv, jiva, cstor)
    • feature (provisioning, backup, restore, exporter)
    • code component (api, webhook, cast, upgrade)
    • test (tests, bdd)
    • chores (version, build, log, travis)
  • subject is a single line brief description of the changes made in the pull request.

@Abhinandan-Purkait
Copy link
Member

Abhinandan-Purkait commented Nov 6, 2024

@rfyiamcool Please sign your commit. Can you please explain the change and the current issue on the PR description?

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (8c402d3) to head (75bce7e).
Report is 6 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #600   +/-   ##
========================================
  Coverage    95.99%   95.99%           
========================================
  Files            1        1           
  Lines          574      574           
========================================
  Hits           551      551           
  Misses          19       19           
  Partials         4        4           
Flag Coverage Δ
bddtests 95.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfyiamcool
Copy link
Author

@rfyiamcool Please sign your commit. Can you please explain the change and the current issue on the PR description?

done 😁

@Abhinandan-Purkait
Copy link
Member

@rfyiamcool Please sign your commit. Can you please explain the change and the current issue on the PR description?

done 😁

I still see the DCO failing. You should check the steps here https://github.com/openebs/zfs-localpv/pull/600/checks?check_run_id=32630888366

@rfyiamcool
Copy link
Author

@rfyiamcool Please sign your commit. Can you please explain the change and the current issue on the PR description?

done 😁

I still see the DCO failing. You should check the steps here https://github.com/openebs/zfs-localpv/pull/600/checks?check_run_id=32630888366

Sorry, it's okay now. 😁

@Abhinandan-Purkait
Copy link
Member

@rfyiamcool Thanks, can you please rebase, once that is done, we can do the merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants