Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix whitelist #6973

Closed
wants to merge 1 commit into from
Closed

fix whitelist #6973

wants to merge 1 commit into from

Conversation

NikulovE
Copy link

@NikulovE NikulovE commented Aug 2, 2023

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@NikulovE
Copy link
Author

NikulovE commented Aug 3, 2023

I`m sorry, this is my first pull requests to opensource projects. But I spent a lot of time to establish building from scratch Open Edx on Ubunut 20.04 following your instructions.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @NikulovE! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@mphilbrick211
Copy link

Hi @NikulovE! Thanks for this contribution - would you mind providing a description for this pull request?

@NikulovE
Copy link
Author

NikulovE commented Aug 7, 2023

Hi @NikulovE! Thanks for this contribution - would you mind providing a description for this pull request?

Hello due Lilac Native installation on Ubuntu 20.04 I've got an error with white List configuration for LMS. I lost installation log but fatal error was about that scheme is require (http or https)

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 7, 2023
@e0d
Copy link
Contributor

e0d commented Aug 16, 2023

Hi @NikulovE , we need to have a valid Contributor License Agreement (CLA) in place for all contributions. See the welcome message above for the details about how to enroll. The process is different depending upon whether you are making this contribution as an individual or on behalf of your employer.

@e0d
Copy link
Contributor

e0d commented Aug 16, 2023

@NikulovE I also notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 16, 2023
@mphilbrick211
Copy link

@NikulovE I also notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

Hi @NikulovE! Just following up on this!

@NikulovE NikulovE closed this Sep 12, 2023
@openedx-webhooks
Copy link

@NikulovE Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@NikulovE
Copy link
Author

Cant continue

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants