feat: Pull edxapp translations via Atlas

[timmc-edx]

This is to support OEP-58:
https://docs.openedx.org/projects/openedx-proposals/en/latest/architectural-decisions/oep-0058-arch-translations-management.html

Changes since the #7119 attempt:

• Move to just after main requirements are installed (just for faster feedback during testing, really)
• Use already-installed openedx-atlas
• Use variant-agnostic EDX_PLATFORM_SETTINGS rather than DJANGO_SETTINGS_MODULE
• Use Ansible environment field for env vars
• Drop set -eu -o pipefail since the script is now simple

Most importantly, openedx/edx-platform#34306 has since merged, so we don't have to worry about the NPM conflicts we were getting previously.

Configuration Pull Request

Make sure that the following steps are done before merging:

• Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
• If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
• Performed the appropriate testing.
• Think about how this change will affect Open edX operators and update the wiki page for the next Open edX release if needed

[OmarIthawi]

@timmc-edx Thanks for creating this I'm happy to see the work getting used :)

It seems to be aligned with how altas is supposed to work in a production environment.

I have two notes which might break future uses:

• EDX_PLATFORM_SETTINGS: production could be the way to go to avoid hitting issues with CMS manage.py calls.
• atlas pull causes the git to be in a ditry state with changed files. Which will break on the second deployment if I'm not mistaken: https://github.com/openedx/configuration/blob/20dacf55a71686fb815fea177489cd726294906f/playbooks/roles/git_clone/tasks/main.yml#L69-L76

I don't think this should be merged as-is.

[OmarIthawi]

I've made some cosmetic suggestions here, but please do not accept it as-is. My Ansible skills are pretty rusty at the moment.

Suggested change

	shell: |
	set -eu -o pipefail
	source {{ edxapp_venv_dir }}/bin/activate
	# Use production Django settings because otherwise debug_toolbar will be referenced and cause
	# an error (we don't have developer Python deps installed.) Use minimal configs because the
	# real configs aren't installed until later in the playbook.
	DJANGO_SETTINGS_MODULE=lms.envs.production LMS_CFG=lms/envs/minimal.yml STUDIO_CFG=lms/envs/minimal.yml \
	OPENEDX_ATLAS_PULL=true make pull_translations
	shell: |
	set -eu -o pipefail
	source {{ edxapp_venv_dir }}/bin/activate
	make pull_translations
	environment:
	# Use production Django settings because otherwise debug_toolbar will be referenced and cause
	# an error (we don't have developer Python deps installed.) Use minimal configs because the
	# real configs aren't installed until later in the playbook.
	EDX_PLATFORM_SETTINGS: "production"
	LMS_CFG: "lms/envs/minimal.yml"
	STUDIO_CFG: "lms/envs/minimal.yml"
	OPENEDX_ATLAS_PULL: "true"

[timmc-edx]

Oh nice, I didn't know Ansible had environment as a field on tasks in general! Also, I can get rid of the set -eu -o pipefail since I no longer have a complicated shell script; the relevant command is the last one.

I'll give EDX_PLATFORM_SETTINGS a shot as well.

[timmc-edx]

It doesn't appear that edxapp uses the git_clone role, at least not directly. (It does use edx-themes, which uses git_clone, but for a different repo.)

This is definitely something to watch out for in other repos, but I don't think it would be relevant for 2U, at least -- we provision brand new hosts and cut AMIs, and then deploy those AMIs. The Ansible scripts only get run once.

[OmarIthawi]

@timmc-edx Thanks for the context about AMI builds at 2U. It's certainly clearner this way.

It's been a couple of years since I tinkered with Ansible, but this looks good to me.

I'm excited to see atlas in action!