feat: Allow instrumenting edxapp with Datadog APM #7136
Conversation
Introduces `COMMON_ENABLE_DATADOG_APP` for APM instrumention with Datadog, as distinct from `COMMON_ENABLE_DATADOG` that just installs the agent (for infrastructure monitoring). See edx/edx-arch-experiments#574
| when: COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP | ||
| pip: | ||
| name: | ||
| - ddtrace |
There was a problem hiding this comment.
Author's note: This doesn't pin any specific version, which makes me a little uncomfortable, but I don't think we would have any way of keeping it up to date. Maybe I should at least add a way to pin it as needed?
There was a problem hiding this comment.
Once this lands, let's add this as a future task to the spreadsheet, but this is a lower priority. Thanks.
timmc-edx
force-pushed
the
timmc/datadog
branch
from
cde1f2b
to
549de43
Compare
| when: COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP | ||
| pip: | ||
| name: | ||
| - ddtrace |
There was a problem hiding this comment.
Once this lands, let's add this as a future task to the spreadsheet, but this is a lower priority. Thanks.
| {% set executable = edxapp_venv_bin + '/gunicorn' %} | ||
|
|
||
| {% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_NEWRELIC_APP %} | ||
| {% set executable = edxapp_venv_bin + '/newrelic-admin run-program ' + executable %} |
There was a problem hiding this comment.
Am I missing something, or does this make New Relic config dependent on the datadog toggle? Maybe the lms.sh.j2 change is what was meant?
There was a problem hiding this comment.
Yikes, good catch. I meant to add that to the other file, not to the newrelic line in the same file!
Introduces
COMMON_ENABLE_DATADOG_APPfor APM instrumention with Datadog, as distinct fromCOMMON_ENABLE_DATADOGthat just installs the agent (for infrastructure monitoring).See edx/edx-arch-experiments#574
Configuration Pull Request
Make sure that the following steps are done before merging: