Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

test: Fix provisioning tests by ignoring maybe-missing google-cloud-sdk #1190

Merged
merged 1 commit into from
Sep 28, 2023
Merged

test: Fix provisioning tests by ignoring maybe-missing google-cloud-sdk #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/provisioning-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ jobs:
docker compose --version

- name: free up disk space
run: sudo apt remove --purge -y ghc-* azure-cli google-cloud-sdk hhvm llvm-* dotnet-* powershell mono-* php* ruby*
# 2023-09-28: google-cloud-sdk removed from this list because it was intermittently
# unavailable as an apt package to remove, and might be migrating to snap. If more
# disk space is needed, see if the snap is installed, and remove that.
run: sudo apt remove --purge -y ghc-* azure-cli hhvm llvm-* dotnet-* powershell mono-* php* ruby*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmc-edx: Is there an alternative that breaks it out on to its own line and swallows errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I'm not sure it's worth it unless we see out-of-space issues again. And in that case, I'd first try removing the snap. But I don't have a lot of experience with snap, so this would take more research.

Interestingly, in February it sounded like GitHub might be planning on not pre-installing this apt package anymore partly due to the age of the package; maybe Ubuntu itself is removing the apt package as well. If that's the case, GitHub probably isn't replacing it with the snap package either.


- name: set up requirements
run: make requirements
Expand Down