-
Notifications
You must be signed in to change notification settings - Fork 35
upgrade pyyaml version to make it compatible with python 3.12.2 #247
upgrade pyyaml version to make it compatible with python 3.12.2 #247
Conversation
closing this PR in favour of #246 |
5c62e4b
to
d180fd1
Compare
f432ae4
to
c735e92
Compare
c735e92
to
085084e
Compare
@feanil Hi, need your assistance in getting this PR reviewed. Thanks Also, I see codecov checks are stuck for other PRs as well. We can ignore it for now. |
ff536b8
to
085084e
Compare
backports-zoneinfo comes by-default in newer versions of python it gives error while building wheel with python>=3.9 100.5 Downloading zope.interface-6.3-cp312-cp312-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (255 kB) 101.6 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 255.4/255.4 kB 223.8 kB/s eta 0:00:00 102.2 Building wheels for collected packages: backports-zoneinfo 102.2 Building wheel for backports-zoneinfo (pyproject.toml): started 102.8 Building wheel for backports-zoneinfo (pyproject.toml): finished with status 'error' 102.8 error: subprocess-exited-with-error 102.8 102.8 × Building wheel for backports-zoneinfo (pyproject.toml) did not run successfully. 102.8 │ exit code: 1 102.8 ╰─> [41 lines of output] 102.8 running bdist_wheel 102.8 running build 102.8 running build_py 102.8 creating build 102.8 creating build/lib.linux-x86_64-cpython-312 102.8 creating build/lib.linux-x86_64-cpython-312/backports 102.8 copying src/backports/__init__.py -> build/lib.linux-x86_64-cpython-312/backports 102.8 creating build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 copying src/backports/zoneinfo/_common.py -> build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 copying src/backports/zoneinfo/_version.py -> build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 copying src/backports/zoneinfo/_zoneinfo.py -> build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 copying src/backports/zoneinfo/__init__.py -> build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 copying src/backports/zoneinfo/_tzpath.py -> build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 running egg_info 102.8 writing src/backports.zoneinfo.egg-info/PKG-INFO 102.8 writing dependency_links to src/backports.zoneinfo.egg-info/dependency_links.txt 102.8 writing requirements to src/backports.zoneinfo.egg-info/requires.txt 102.8 writing top-level names to src/backports.zoneinfo.egg-info/top_level.txt 102.8 reading manifest file 'src/backports.zoneinfo.egg-info/SOURCES.txt' 102.8 reading manifest template 'MANIFEST.in' 102.8 warning: no files found matching '*.png' under directory 'docs' 102.8 warning: no files found matching '*.svg' under directory 'docs' 102.8 no previously-included directories found matching 'docs/_build' 102.8 no previously-included directories found matching 'docs/_output' 102.8 adding license file 'LICENSE' 102.8 adding license file 'licenses/LICENSE_APACHE' 102.8 writing manifest file 'src/backports.zoneinfo.egg-info/SOURCES.txt' 102.8 copying src/backports/zoneinfo/__init__.pyi -> build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 copying src/backports/zoneinfo/py.typed -> build/lib.linux-x86_64-cpython-312/backports/zoneinfo 102.8 running build_ext 102.8 building 'backports.zoneinfo._czoneinfo' extension 102.8 creating build/temp.linux-x86_64-cpython-312 102.8 creating build/temp.linux-x86_64-cpython-312/lib 102.8 gcc -pthread -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall -fPIC -I/openedx/venv/include -I/opt/pyenv/versions/3.12.2/include/python3.12 -c lib/zoneinfo_module.c -o build/temp.linux-x86_64-cpython-312/lib/zoneinfo_module.o -std=c99 102.8 lib/zoneinfo_module.c: In function ‘zoneinfo_fromutc’: 102.8 lib/zoneinfo_module.c:600:19: error: ‘_PyLong_One’ undeclared (first use in this function); did you mean ‘_PyLong_New’? 102.8 600 | one = _PyLong_One; 102.8 | ^~~~~~~~~~~ 102.8 | _PyLong_New 102.8 lib/zoneinfo_module.c:600:19: note: each undeclared identifier is reported only once for each function it appears in 102.8 error: command '/usr/bin/gcc' failed with exit code 1 102.8 [end of output] 102.8 102.8 note: This error originates from a subprocess, and is likely not a problem with pip. 102.8 ERROR: Failed building wheel for backports-zoneinfo 102.8 Failed to build backports-zoneinfo 102.8 ERROR: Could not build wheels for backports-zoneinfo, which is required to install pyproject.toml-based projects ------ Dockerfile:83 -------------------- 81 | 82 | # python requirements 83 | >>> RUN --mount=type=cache,target=/openedx/.cache/pip,sharing=shared,uid=${APP_USER_ID} pip install -r requirements.txt 84 | # https://pypi.org/project/uWSGI/ 85 | RUN --mount=type=cache,target=/openedx/.cache/pip,sharing=shared,uid=${APP_USER_ID} pip install uwsgi==2.0.24 -------------------- ERROR: failed to solve: process "/bin/sh -c pip install -r requirements.txt" did not complete successfully: exit code: 1
Hi @DawoudSheraz, @feanil I will make a review of this next week :D |
Hi everyone I was testing this PR, and I found some problems related to the tutor image creation. In this PR you are increasing Celery and that makes incompatible this line in the tutor ecommerce-worker image. After I changed the command I could use the celery v5.4.0 in the worker. Finally, I think this PR solves the problem. |
This is a proposal in order to allow ecommerce-worker increase celery to v5.4.7. This upgrade of celery in the following PR: openedx-unsupported/ecommerce-worker#247
This is a proposal in order to allow ecommerce-worker increase celery to v5.4.0 This upgrade of celery in the following PR: openedx-unsupported/ecommerce-worker#247
This is a proposal in order to allow ecommerce-worker increase celery to v5.4.0 This upgrade of celery in the following PR: openedx-unsupported/ecommerce-worker#247
@johanseto Hi. Yes, the PR to upgrade tutor-ecommerce plugin has been up for a while. It would be merged once this and openedx/ecommerce related PRs are merged. |
I updated the repo to not require the codecov checks and removed the rev squad as a required reviewer. |
pyyaml==6.0 is not compatible with python 3.12.
pyyaml==6.0.1 is compatible with python 3.8.0 to 3.12.2.
celery=4.x is also not compatible with 3.12.2. It throws below error
backports-zoneinfo comes by-default in newer versions of python
it gives error while building wheel with python>=3.9
Upgraded Celery in this PR through constraints.txt which also resolves other dependencies conflicts with python 3.12.2.
This change is necessary to be merged to close this issue in tutor-ecommerce.