Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Paragon table deprecation migration to DataTable #191

Closed

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated Table component of paragon and updated it with DataTable

References

Paragon Table
Paragon DataTable

@abdullahwaheed abdullahwaheed requested a review from a team June 16, 2022 11:06
@abdullahwaheed abdullahwaheed self-assigned this Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #191 (78479ff) into master (2179457) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files          15       15           
  Lines         164      164           
  Branches       28       28           
=======================================
  Hits           80       80           
  Misses         79       79           
  Partials        5        5           
Impacted Files Coverage Δ
src/order-history/OrderHistoryPage.jsx 78.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2179457...78479ff. Read the comment docs.

Copy link
Contributor

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

Copy link
Contributor

@julianajlk julianajlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this change for us (revenue-squad)!
I believe you need to add <DataTable.Table /> as a child of the DataTable component, otherwise it will show Showing 7 of 7. bit which we don't want to in the Order History page.

@pshiu
Copy link
Contributor

pshiu commented Jul 12, 2022

Please ping #revenue-squad when this is ready to merge!

@abdullahwaheed
Copy link
Contributor Author

Please ping #revenue-squad when this is ready to merge!

I am unable to push my changes on this repo now, let me create a fork and a new PR from there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants