This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
chore: backport upgrade to node 18 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
…dx-unsupported#274) * feat: upgraded to node v18, added .nvmrc and updated workflows * build: update frontrnf-build * build: upgrade pkgs * build: update @edx/browserslist-config to the latest * refactor: update packages
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @regisb! As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
pshiu
approved these changes
Jun 12, 2023
arbrandes
approved these changes
Jun 12, 2023
|
@regisb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport the following changes:
#274
#278
These backports are necessary to build the microfrontend apps of the ecommerce application in the open-release/palm.master branch with node 18 (and not node 16).
Supporting information
Issue was raised here: openedx/wg-build-test-release#261 (comment)
Testing instructions
Check that this version builds with the "palm" branch of the tutor-ecommerce plugin: overhangio/tutor-ecommerce#42