-
Notifications
You must be signed in to change notification settings - Fork 47
feat: Add grey color for disabled selects during the form submission #865
Conversation
Thanks for the pull request, @Lunyachek! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a212113
to
c4468dd
Compare
a8a8763
to
c454527
Compare
The failed tests are not related to the changes in this PR. Can someone help troubleshoot this issue? |
@Lunyachek it looks like the issue is that master has some dependencies that have security issues that are out of date and have known vulnerabilities in them that need to be resolved. Looks like the full test suite ran and passed so I think this is safe to merge so I'm gonna |
To make sure we're all on the same page, we should only consider merging this PR after the one to master lands. |
@arbrandes thanks for the catch, missed that this was on the quince branch, that explains the out of date dependencies. So in general, this should be safe to merge once the one on master lands. |
@arbrandes are you able to merge this now that the master is all set? |
@arbrandes @mphilbrick211 I believe everything is ready for the final review and merging of this pull request into the quince branch. Could we proceed with that? |
@arbrandes @brian-smith-tcril - is one of you able to take a look at this? |
The changes here look identical to the changes to master. I hadn't merged this before because of CI failures, but it seems they are just the allowlist errors that I noticed here. I'm happy to merge this as-is. |
5f69acc
into
openedx-unsupported:open-release/quince.master
This is backport from master - #715
Description
This cosmetic enhancement for payment form. After pressing "Place Order" button - we can see that all inputs became disabled, but selects - no. It looks not consistent and we decided to fix this small issue.
2023-03-06.11.53.26.mov
The result:
2023-03-02.14.43.17.mov