Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Conversation

magajh
Copy link

@magajh magajh commented Feb 6, 2024

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @magajh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c06d229) 74.74% compared to head (c1f9b33) 74.74%.
Report is 1 commits behind head on open-release/quince.master.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           open-release/quince.master     #733   +/-   ##
===========================================================
  Coverage                       74.74%   74.74%           
===========================================================
  Files                             105      105           
  Lines                            8585     8585           
===========================================================
  Hits                             6417     6417           
  Misses                           2168     2168           
Flag Coverage Δ
unittests 74.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmltaWt0
Copy link

cmltaWt0 commented Feb 7, 2024

I've build it locally via Dockerfile and I'm able to run it.

@magajh we forgot to update the master branch with this security patch last time.
Please ensure it is done this time.
The master is still on 3.2.22

@cmltaWt0 cmltaWt0 merged commit 55504ed into openedx-unsupported:open-release/quince.master Feb 7, 2024
5 checks passed
@openedx-webhooks
Copy link

@magajh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@magajh magajh deleted the magajh/patch-django-quince-3.2.24 branch February 7, 2024 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants