116: Add Support for Python 3.11 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullahQureshee
force-pushed
the
maq/116
branch
from
12c2dff to
6f8eb42
Compare
farhan
suggested changes
Nov 12, 2024
code_annotations/__init__.py
Outdated
| @@ -2,4 +2,4 @@ | |||
| Extensible tools for parsing annotations in codebases. | |||
| """ | |||
|
|
|||
| __version__ = '1.8.0' | |||
| __version__ = '1.9.0' | |||
There was a problem hiding this comment.
It should be 2.0.0 as we are dropping support of python 3.8
|
Looks good to me if you can get a green build 👍 |
|
A lot of this work has been caught up on as I've got the Python requirements running and merged the dependabot PRs. I think you've still got some changes we need in here, though, if you want to rebase and take a look. |
abdullahQureshee
force-pushed
the
maq/116
branch
3 times, most recently
from
e7a43e6 to
db16421
Compare
|
Nice, almost there. I think we can skip the requirements txt files changes, since those should be run automatically every week now. So if you remove those and fix the commit message to match the format here I can merge this. Thanks for the work! https://open-edx-proposals.readthedocs.io/en/latest/best-practices/oep-0051-bp-conventional-commits.html |
abdullahQureshee
force-pushed
the
maq/116
branch
from
db16421 to
651b005
Compare
bmtcril
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: resolves #116
JIRA: Link to JIRA ticket
Dependencies: nil
Merge deadline: nil
Installation instructions: nil
Testing instructions:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: nil