build: Switch to ubuntu-latest for builds #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this might be broken because the underlying tests were assuming that Python 3.8 would always be available but since newer versions of Ubuntu don't have it by default, tests are failing. It looks like when this repo was updated to test with python 3.11, the underlying cookiecutters were not themselves updated to run on Python 3.11/3.12. That work will need to be done and python 3.8 support properly dropped before we can cleanly do this update. |
Merged
This code does not have any dependencies that are specific to any specific version of ubuntu. So instead of testing on a specific version and then needing to do work to keep the versions up-to-date, we switch to the ubuntu-latest target which should be sufficient for testing purposes. This work is being done as a part of openedx/platform-roadmap#377 closes #478
We're now building with 3.12 here so make sure `make upgrade` is run with python 3.12
feanil
force-pushed
the
feanil/ubuntu_upgrade
branch
from
5323f37 to
e333a67
Compare
robrap
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Won't you want to update the templates as well? See https://github.com/search?q=repo%3Aopenedx%2Fedx-cookiecutters%20%22ubuntu-%22&type=code
|
Ah, thank you! Missed those! |
|
Ready to review now. |
robrap
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code does not have any dependencies that are specific to any specific
version of ubuntu. So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.
This work is being done as a part of openedx/platform-roadmap#377
closes #478