Skip to content

Commit

Permalink
fix: Use Locator property block_id.
Browse files Browse the repository at this point in the history
This change has been made to address 9 deprecation warnings which
can be seen after the tests are run.

`name` property of Locators has been deprecated and replaced by the
`block_id` property.
  • Loading branch information
lewisemm committed Feb 6, 2024
1 parent 5e732f9 commit 65e244e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cms/templates/checklists.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ <h2 class="page-header">
"id": "${context_course.id | n, js_escaped_string}",
"name": "${context_course.display_name_with_default | n, js_escaped_string}",
"is_course_self_paced": ${context_course.self_paced | n, dump_js_escaped_json},
"url_name": "${context_course.location.name | n, js_escaped_string}",
"url_name": "${context_course.location.block_id | n, js_escaped_string}",
"org": "${context_course.location.org | n, js_escaped_string}",
"num": "${context_course.location.course | n, js_escaped_string}",
"display_course_number": "${context_course.display_coursenumber | n, js_escaped_string}",
Expand Down
2 changes: 1 addition & 1 deletion cms/templates/container.html
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ <h5 class="title">${_("Location ID")}</h5>
"course": {
"id": "${context_course.id | n, js_escaped_string}",
"name": "${context_course.display_name_with_default | n, js_escaped_string}",
"url_name": "${context_course.location.name | n, js_escaped_string}",
"url_name": "${context_course.location.block_id | n, js_escaped_string}",
"org": "${context_course.location.org | n, js_escaped_string}",
"num": "${context_course.location.course | n, js_escaped_string}",
"display_course_number": "${context_course.display_coursenumber | n, js_escaped_string}",
Expand Down

0 comments on commit 65e244e

Please sign in to comment.