fix: fixed non Attribute error when a report hasn't been sent yet

openedx · Jan 12, 2024 · 7efc777 · 7efc777
1 parent e1124b7
commit 7efc777
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lms/templates/admin/base_site.html b/lms/templates/admin/base_site.html
@@ -23,4 +23,4 @@ <h1 id="site-name"><a href="{% url 'admin:index' %}">{{ site_header|default:_('D
 
 {% block messages %}{{ block.super }}
     {% include "survey_report/admin_banner.html" %}
-{% endblock %}
+{% endblock %}
diff --git a/openedx/features/survey_report/admin.py b/openedx/features/survey_report/admin.py
@@ -85,9 +85,11 @@ def report_state(self, obj):
         Method to define the custom State column with the new "send" state,
         to avoid modifying the current models.
         """
-        if obj.surveyreportupload_set.last().is_uploaded():
-            return "Sent"
-        return obj.state.capitalize()
+        try:
+            if obj.surveyreportupload_set.last().is_uploaded():
+                return "Sent"
+        except AttributeError:
+            return obj.state.capitalize()
     report_state.short_description = 'State'
 
 admin.site.register(SurveyReport, SurveyReportAdmin)