feat: add brand_color variable for the email templates #33421
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @bydawen! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hi! I'm contributing on behalf of Raccoongang |
bydawen
force-pushed
the
feat/master/email-template-color-branding
branch
from
d4cd264 to
4dd9300
Compare
bydawen
changed the title
bydawen
changed the title
dyudyunov
force-pushed
the
feat/master/email-template-color-branding
branch
from
07a365a to
7e8021c
Compare
|
Hi @bydawen and @dyudyunov! Is this ready for review? |
@mphilbrick211 hello, yes it's ready for review, thank you) |
|
Hi @openedx/fed-bom! Is this something you could review / merge for us? |
mphilbrick211
added
the
backport
|
Hi @openedx/fed-bom! I'm not sure if you are the correct squad, but if so, could someone please review and merge this for us? Thanks! |
bydawen
force-pushed
the
feat/master/email-template-color-branding
branch
from
bd1619e to
c920000
Compare
bydawen
force-pushed
the
feat/master/email-template-color-branding
branch
from
c920000 to
75b1eb9
Compare
|
Hi @BilalQamar95! Are you able to merge this along with the backport? |
mphilbrick211
removed
the
backport
|
Hi @mphilbrick211, we do have this in sight and will be merging this along with backport soon. Thank you |
|
@BilalQamar95 Hello, are there any estimates regarding the merge date for this and Quince backport? Thanks |
@GlugovGrGlib We plan to merge this within this week |
| 'your édX account from', | ||
| old_email, | ||
| new_email, |
There was a problem hiding this comment.
why have you updated these formatted strings?
There was a problem hiding this comment.
because the inline styling was applied to emails
Here is how it used in the template and actual changes for the email variables
|
Hi @abdullahwaheed! Are you able to merge this for us? |
i'll merge it tomorrow |
|
@bydawen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This reverts commit 4ec70eb. This commit introduced a new setting (`brand_color`) that does not appear to be set and is causing issues with account deletion and other parts of the courseware. Reverting until we can understand the change better.
revert: add brand_color variable for the email templates (#33421)"
Added a color variable to simplify branding of email templates used on different platforms. Also added a variable for the maximum height of the email logo image.
The main purpose of adding these variables is to be able to control the color used on buttons, links, etc. in emails. To avoid making these changes in many files, it can now be done by changing the value of one variable in the
base_bodytemplate.For example, as in the screenshot below, the size of the logo, the color of the button and links affected by brand_color variable which is setted here with the logo height.
{% with brand_color="#1b511a" logo_max_height="65px" %}Similar PR is opened to the open-release/palm branch:
#33420