-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add brand_color variable for the email templates #33606
feat: add brand_color variable for the email templates #33606
Conversation
Thanks for the pull request, @bydawen! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi! I'm contributing on behalf of Raccoongang and PR is ready for review, thanks! |
Hi @bydawen! It looks like there's a failing check. Would you mind taking a look before we send to review? Thanks! |
dbc97b9
to
56f25ba
Compare
@mphilbrick211 hello, tests are fixed, ready to go on review, thanks! |
56f25ba
to
3154bf9
Compare
We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against quince.master once that happens. Thanks! |
Hey @mariajgrimaldi 👋 What did you mean by
I may misunderstand something, but the named master branches are never merged. (ref) |
Mater PR is merged, but then reverted next day. |
Hi @bydawen! Can this be closed, or does it need to remain open as a draft? |
Closing for now due to inactivity. |
@bydawen Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Added a color variable to simplify branding of email templates used on different platforms. Also added a variable for the maximum height of the email logo image.
The main purpose of adding these variables is to be able to control the color used on buttons, links, etc. in emails. To avoid making these changes in many files, it can now be done by changing the value of one variable in the
base_body
template.For example, as in the screenshot below, the size of the logo, the color of the button and links affected by brand_color variable which is setted here with the logo height.
{% with brand_color="#1b511a" logo_max_height="65px" %}
Similar PR is opened to the master branch:
#33421