-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export tagged course as csv #34091
feat: export tagged course as csv #34091
Conversation
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
23ade2b
to
52bc665
Compare
openedx/core/djangoapps/content_tagging/rest_api/v1/serializers.py
Outdated
Show resolved
Hide resolved
9858cd3
to
b01d6d4
Compare
openedx/core/djangoapps/content_tagging/rest_api/v1/serializers.py
Outdated
Show resolved
Hide resolved
…into rpenido/fal-3610-download-course-tag-spreadsheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this on my devstack
- Use https://github.com/open-craft/taxonomy-sample-data/ to create some tagged content.
- Using the "Export tags" menu added by feat: add export course tags menu frontend-app-authoring#830, exported tags for http://localhost:2001/course/course-v1:SampleTaxonomyOrg2+STC1+2023_1
- Checked that course tags appear where expected.
- Tested that exporting tags for an untagged courses works as expected (no taxonomies, no tags in the CSV): http://localhost:2001/course/course-v1:edX+DemoX+Demo_Course/export/
- Imported the CSV files into Google Sheets to verify that the course tree nesting is preserved as expected.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate.
- Includes documentation (docstrings)
-
User-facing strings are extracted for translationN/A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please just make this one change and then I can merge.
Co-authored-by: Braden MacDonald <[email protected]>
@bradenmacdonald This is ready for a final review and merge! |
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR implements a feature to export a CSV with the course structure and its blocks, showing all tags applied to them.
More information
Part of:
Depends on:
Testing instructions
Private-ref: FAL-3610