Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export tagged course as csv #34091
feat: export tagged course as csv #34091
Changes from 12 commits
52bc665
f275908
a870dfd
4dd027a
5fb03aa
8f1238e
bdedf93
04ca072
a8a6e7e
b01d6d4
0871537
18a8425
38ae353
b65a6c8
f5ac3a6
debf254
9726d6d
c8c12bb
1f11b17
484c042
6b6ba34
9096454
a688689
30e06d0
35a3d2b
1e13f54
e9335c8
ab1a69e
db9116d
9b3dee8
821e216
6207915
35bc860
7a28742
fabb729
548d57c
a1d41fd
f07b841
233135a
ac98812
309ce94
32cdf93
4ed7570
ee5bc3d
4bc8ca7
6d4c23a
da3fdf9
726b7ef
fd5a542
79a1786
dfe43be
5245264
c82e9cb
01b9b5f
f87fc4c
779cc98
4a3d092
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not good practice to have an inner function with parameters that have the same names as the outer function. It's unclear if they have the same or different values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense to me. Given a random leaf XBlock A in a course, this will still try to load the ObjectTags for all other XBlocks in the course, none of which are children of XBlock A. I think you can just remove this whole branch of the
if
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This optimization attempted to load all required ObjectTags beforehand with a single query. The other alternatives were:
This is not necessary for a leaf XBlock, but it would help if the XBlock has children.
This should go anyway because we will remove the UsageKey option.