-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed error: ImportError: No module named notmigrations #17850
Conversation
Thanks for the pull request, @amir-qayyum-khan! I've created OSPR-2329 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
Your PR has finished running tests. |
@edx/platform-team A little Django 1.11 work left? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me, but you might hit other issues using ./manage.py test
; we now typically run tests using either paver or pytest. We hadn't hit this issue before because pytest-django uses the --nomigrations
command line option, and our test runs weren't really looking at the MIGRATION_MODULES
setting.
@amir-qayyum-khan 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, April 03, 2018. |
@jmbowman can you guid us what approach should we use for testing xblocks. Right know we use this command for testing our xblock SGA.
|
EdX Release Notice: This PR has been deployed to the production environment. |
@amir-qayyum-khan I just got the tests to run via |
thanks for your feedback @jmbowman, i made issue on SGA to look into this mitodl/edx-sga#240 |
Background:
Was facing exception on running SGA xblock on master.
solution:
picked this solution https://stackoverflow.com/questions/46002731/upgrading-to-django-1-11-4-importerror
@pdpinch @nedbat @ormsbee