-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade bootstrap to 4.6.0 #27751
fix: upgrade bootstrap to 4.6.0 #27751
Conversation
Do this since some mixins in bootstrap depend on others
The mixin changed to accept a single parameter
Your PR has finished running tests. There were no failures. |
Thanks for the pull request, @abutterworth! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the |
This work has stalled. See #31616. |
@abutterworth Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Upgrade bootstrap to 4.6.0. This version of bootstrap requires a newer version of libsass than exists in the platform today. So it builds off of https://github.com/edx/edx-platform/pull/27683.
Changes:
border-radius
mixin now accepts a single parameter instead of 4. Usages have been updated to reflect this.