Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade bootstrap to 4.6.0 #27751

Conversation

abutterworth
Copy link
Contributor

@abutterworth abutterworth commented May 27, 2021

Upgrade bootstrap to 4.6.0. This version of bootstrap requires a newer version of libsass than exists in the platform today. So it builds off of https://github.com/edx/edx-platform/pull/27683.

Changes:

  • The border-radius mixin now accepts a single parameter instead of 4. Usages have been updated to reflect this.
  • In a build.scss file a handful of mixins were imported, but not all. This caused a break since some mixins depend on others. This PR just imports all the bootstrap mixins.
file prod this PR + https://github.com/edx/edx-themes/pull/737
lms-course.css 778kb 1.4mb
lms-discussion-bootstrap.css 189kb 210kb
lms-footer-edx.css 389kb 105kb
lms-main-v1.css 2.2mb 1.3mb
lms-main.css 1.3mb 371kb
studio-main-v1.css 1.1mb 2.1mb

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@openedx-webhooks
Copy link

Thanks for the pull request, @abutterworth! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@kdmccormick
Copy link
Member

This work has stalled. See #31616.

@openedx-webhooks
Copy link

@abutterworth Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@kdmccormick kdmccormick deleted the abutterworth/update-bootstrap branch July 5, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants