fix: account activation email site logo is not themed

[dyudyunov]

Fix the issue when the email sent from the microsite with its own theme
has the logo from the main site.

Preconditions:

• microsite with its own theme is up and running

STR:

• Create a new account on the microsite;
• Check your email inbox.

Related PR to the open-release/maple.master:

• fix: account activation email site logo is not themed #29765

[openedx-webhooks]

Thanks for the pull request, @dyudyunov! I've created OSPR-6390 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[natabene]

@dyudyunov Thank you for your contribution. We will try to review soon.

[felipemontoya]

I added myself as reviewer here and read through the code. The fix looks correct.
I am firing up my devstack now to test. Will report later about this.

@dyudyunov thanks for the contribution. Could you give this a rebase so that checks run again and the check migration is able to run on the new version?

[felipemontoya]

I tested it and it works. However, @dyudyunov keep in mind that the whole site_configuration feature is soon being deprecated as per: openedx/platform-roadmap#21

[dyudyunov]

I tested it and it works. However, @dyudyunov keep in mind that the whole site_configuration feature is soon being deprecated as per: openedx/platform-roadmap#21

Hi @felipemontoya!
Thank you for the review and info.
Yeah, I've just found info about mentioned depreciation last Friday :)
I'll rebase ASAP

[OmarIthawi]

Thanks @dyudyunov and @felipemontoya.

Not sure if it's a lot to ask, since the feature is going to be deprecated but do you think adding a test case worth the effort in this pull request?

[felipemontoya]

I leave that to you @dyudyunov, given the simplicity I would be ok merging as is, but Omar does raise a good point with the test.

[dyudyunov]

Hi, @felipemontoya, @OmarIthawi
To be honest, I don't think adding tests is worth the effort in this case, so I suggest merging it as it is for now 🙂

[natabene]

@felipemontoya Please feel free to merge, just be mindful of merging times guidelines for the repo.

[openedx-webhooks]

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.