Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: fix npm cli by marking fsevents optional #30480

Closed

Conversation

ghassanmas
Copy link
Member

Description

Attempt to fix npm ci by marking an instance of fsevents as optinal in package-lock.json

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 25, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented May 25, 2022

Thanks for the pull request, @ghassanmas! I've created OSPR-6720 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@natabene
Copy link
Contributor

@ghassanmas Thank you for the contribution, is this ready for our review?

@ghassanmas
Copy link
Member Author

@natabene this was an attemp to fix something when nutmeg.master was usign node 16, but however since nutmeg.master is now using node 12 again. This change may not make much sense. I will mark it as WIP, so may be it would be useful/relavant in the future.

@ghassanmas ghassanmas changed the title fix: fix npm cli by marking fsevents optional [WIP] fix: fix npm cli by marking fsevents optional Jun 1, 2022
@ghassanmas ghassanmas marked this pull request as draft June 1, 2022 07:44
@mphilbrick211
Copy link

Hi @ghassanmas can this be closed?

@ghassanmas
Copy link
Member Author

ghassanmas commented Dec 27, 2022

Yes this was for testing/experiments purpose.

Edit: oh no it wasn't for experiments purpose I was referring to other PR.

In any case this change is related to nutmeg which if we don't actually support then this should be closed.

In case we still need to support nutmeg, I will need to give another look/revisit before giving an opinion

@mphilbrick211
Copy link

Hi @ghassanmas - just checking back on this - can this be closed?

@ghassanmas
Copy link
Member Author

@mphilbrick211 we can in favour #31887 which a candidate for fixing a the same problem (part of it)

@ghassanmas ghassanmas closed this Apr 4, 2023
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants