-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix: fix npm cli by marking fsevents optional #30480
[WIP] fix: fix npm cli by marking fsevents optional #30480
Conversation
Thanks for the pull request, @ghassanmas! I've created OSPR-6720 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
@ghassanmas Thank you for the contribution, is this ready for our review? |
@natabene this was an attemp to fix something when nutmeg.master was usign node 16, but however since nutmeg.master is now using node 12 again. This change may not make much sense. I will mark it as WIP, so may be it would be useful/relavant in the future. |
Hi @ghassanmas can this be closed? |
Edit: oh no it wasn't for experiments purpose I was referring to other PR. In any case this change is related to nutmeg which if we don't actually support then this should be closed. In case we still need to support nutmeg, I will need to give another look/revisit before giving an opinion |
Hi @ghassanmas - just checking back on this - can this be closed? |
@mphilbrick211 we can in favour #31887 which a candidate for fixing a the same problem (part of it) |
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Attempt to fix
npm ci
by marking an instance offsevents
as optinal inpackage-lock.json