Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: incrementally upgrade npm packages #30953

Conversation

ishahroz
Copy link

@ishahroz ishahroz commented Sep 7, 2022

Ticket

openedx/wg-frontend#105

Description

  1. Upgraded React v16.1.0 to v16.14.0.
  2. Upgraded React-DOM v16.1.2 to v16.14.0.
  3. All packages with patch updates are upgraded.
  4. Most of the packages with minor version updates are upgraded. Remaining are prop-types, redux-thunk and underscore. If I try to upgrade these packages, test suite starts to fail.
  5. Some of the packages with major version updates are upgraded. But packages related to WebPack, Bootstrap, edx-paragon, Karma, Jest and Selenium starts to break if I attempt to update them.
  6. For all the packages I updated, all the test suite are successfully passed and also the website is functional.
  7. I have done work in multiple commits which means I tried to upgrade some packages in batch and ran test cases on them. And then repeated the same steps.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 7, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @ishahroz! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@natabene
Copy link
Contributor

natabene commented Sep 7, 2022

@ishahroz Thank you for your contribution. Once you've submitted a signed contributor agreement and it has been processed, I will update here, and we will be able to review your code.

@ishahroz ishahroz force-pushed the chore-incrementally-upgrade-npm-packages branch from 1f690c4 to ece565d Compare September 27, 2022 04:01
@natabene natabene changed the title chore: incrementally upgrade npm packages chore: incrementally upgrade npm packages Sep 27, 2022
@natabene natabene changed the title chore: incrementally upgrade npm packages chore: incrementally upgrade npm packages Sep 27, 2022
@natabene natabene changed the title chore: incrementally upgrade npm packages chore: incrementally upgrade npm packages Oct 13, 2022
@natabene natabene changed the title chore: incrementally upgrade npm packages chore: incrementally upgrade npm packages Oct 13, 2022
@bradenmacdonald
Copy link
Contributor

@ishahroz What's the status of this PR?

@nedbat
Copy link
Contributor

nedbat commented Oct 31, 2022

📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to keep passing required checks.

We added a new required check, "Tests Successful," that this PR does not yet run. Rebasing will get it started.

If you have any questions, please reach out to the Architecture team (either #architecture on Open edX Slack or #external-architecture on edX internal Slack).

@ishahroz
Copy link
Author

ishahroz commented Nov 3, 2022

Hi @bradenmacdonald, this PR is under the work. Actually, some work was left regarding to upgrade Karam and its related dependences to mitigate produced security issues. We were facing issues while trying to upgrade Karma to newer versions. Now after discussing with @jmbowman, we are trying to plan out ways to remove Karma and instead integrate Jest in "edx-platform". You can also consult some of initial observations regarding test migration by going to the following link:

https://docs.google.com/document/d/1jlPaCLu2Vx-V5EsfM8v0JTTjUqowxLuEtzUH3nTpUus/edit?usp=sharing

@mphilbrick211
Copy link

@jmbowman based on @ishahroz's last comment, just checking to see if there's an update on this?

@mphilbrick211
Copy link

Hi @jmbowman and @ishahroz - friendly follow-up on this. Is there an update?

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Feb 7, 2023
@mphilbrick211
Copy link

Hi @ishahroz and @jmbowman - It looks like this pull request may be inactive. Do you have an update on if this is being pursued? If not, we will close it for the time being. Thanks!

@BilalQamar95
Copy link
Contributor

BilalQamar95 commented Feb 10, 2023

Hi @mphilbrick211, since this is from a forked repo I was unable to add new commits to this PR. I have made a new PR for it updating the packages & it is passing all test cases. Closing this PR in favor of 31739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive PR author has been unresponsive for several months open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants