-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: incrementally upgrade npm packages #30953
chore: incrementally upgrade npm packages #30953
Conversation
Thanks for the pull request, @ishahroz! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@ishahroz Thank you for your contribution. Once you've submitted a signed contributor agreement and it has been processed, I will update here, and we will be able to review your code. |
…o mitigate security issue
…lodash security issue
…o chore-incrementally-upgrade-npm-packages
1f690c4
to
ece565d
Compare
@ishahroz What's the status of this PR? |
📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to keep passing required checks. We added a new required check, "Tests Successful," that this PR does not yet run. Rebasing will get it started. If you have any questions, please reach out to the Architecture team (either #architecture on Open edX Slack or #external-architecture on edX internal Slack). |
Hi @bradenmacdonald, this PR is under the work. Actually, some work was left regarding to upgrade Karam and its related dependences to mitigate produced security issues. We were facing issues while trying to upgrade Karma to newer versions. Now after discussing with @jmbowman, we are trying to plan out ways to remove Karma and instead integrate Jest in "edx-platform". You can also consult some of initial observations regarding test migration by going to the following link: https://docs.google.com/document/d/1jlPaCLu2Vx-V5EsfM8v0JTTjUqowxLuEtzUH3nTpUus/edit?usp=sharing |
Hi @mphilbrick211, since this is from a forked repo I was unable to add new commits to this PR. I have made a new PR for it updating the packages & it is passing all test cases. Closing this PR in favor of 31739 |
Ticket
openedx/wg-frontend#105
Description