-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LEARNER-8790 Support Apple team Migration #31861
Conversation
UPDATED:
Please lean on Arch-BOM to help in any way we can to reduce friction on this request. Thank you! |
@robrap Thanks for your comments! This change may come off as 2u-specific at first glance. But since edx-platform supports Sign in with Apple, the feature implemented here adds value to the platform over-all. i.e. In the event of switching apple teams, the platform will support migrating apple users from one team to another. Secondly, I have overriden the function This is also a dependency/blocker in a major in-app Purchases release Mobile team is ready for. Please let me know your thoughts given the info above. Thank you! |
@moeez96: Thanks. That sounds reasonable. If you want this to be a feature, maybe move some of the PR description documentation to a how-to (following OEP-19 for location in a local docs/how_to directory (might be how_tos). |
@robrap Done, Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good, but I think we should remove/replace references to edx
in the documentation.
|
||
This document explains how to migrate apple signed-in users in the event of | ||
switching teams on the Apple Developer console. When a user uses Apple to sign in, | ||
edx receives an `id_token from apple containing user information`_, including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not refer to edx
specifically, especially if we want this to be general Open edX documentation. Maybe say LMS
or edx-platform
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dianakhuang. I replaced occurrences of edx
with LMS
.
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
EdX Release Notice: This PR has been deployed to the production environment. |
Description
Apple account that belongs to edx is to be transferred from edx Inc. to edx LLC. The unique apple_id for users (stored in social_django.models.UserSocialAuth.uid) is team-scoped i.e. unique to the owner team at Apple. As a result, We need to follow steps to migrate Apple ID's for users who sign in with Apple on edx.
This PR aims to support the Apple team migration process meanwhile allowing users to sign-in seamlessly throughout the process.
Steps:
generate_and_store_apple_transfer_ids
is run to generate transfer_identifiers for apple users. We store these transfer identifiers in the TableAppleMigrationUserIdInfo
along with the current apple uid. After migration, we will use temporarily use these transfer_identifiers to match with the apple uid and allow existing users to sign in. Once step 4 is executed, use of these transfer_identifiers will end and the system will return back to normal.generate_and_store_apple_transfer_ids
is run that fetches apple uid's for the new team and stores them in theAppleMigrationUserIdInfo
table.update_new_apple_ids_in_social_auth
is run that replaces the old team-scoped apple ids' in UserSocialAuth table with the new team-scoped apple Ids.Supporting information
Deadline
8th March 2023. Reason: Blocking iOS in-app purchases release.
Other information
apple-id
with new Client ID and Client Secret.