Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply amnesty on existing not fixable issues #32215

Merged
merged 37 commits into from
Aug 7, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
148ca9b
fix: eslint operator-linebreak issue
Syed-Ali-Abbas-Zaidi Mar 7, 2023
3cecf21
fix: eslint quotes issue
Syed-Ali-Abbas-Zaidi Mar 7, 2023
b2fb0e1
fix: react jsx indent and props issues
Syed-Ali-Abbas-Zaidi Mar 7, 2023
cf53f88
fix: eslint trailing spaces issues
Syed-Ali-Abbas-Zaidi Mar 7, 2023
02cf040
fix: eslint line around directives issue
Syed-Ali-Abbas-Zaidi Mar 7, 2023
aa3431a
fix: eslint semi rule
Syed-Ali-Abbas-Zaidi Mar 9, 2023
40ac89d
fix: eslint newline per chain rule
Syed-Ali-Abbas-Zaidi Mar 9, 2023
83dee98
fix: eslint space infix ops rule
Syed-Ali-Abbas-Zaidi Mar 9, 2023
da2f67d
fix: eslint space-in-parens issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
01dd648
fix: eslint space before function paren issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
3f3b352
fix: eslint space before blocks issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
81b8290
fix: eslint arrow body style issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
335ab97
fix: eslint dot-location issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
45f5fa3
fix: eslint quotes issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
3640611
fix: eslint quote props issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
0aff1d3
fix: eslint operator assignment issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
b9337ec
fix: eslint new line after import issue
Syed-Ali-Abbas-Zaidi Mar 9, 2023
f641a0e
fix: indent issues
Syed-Ali-Abbas-Zaidi May 3, 2023
8915030
fix: operator assignment issue
Syed-Ali-Abbas-Zaidi May 4, 2023
30db206
fix: all autofixable eslint issues
Syed-Ali-Abbas-Zaidi May 4, 2023
b5c7a3c
fix: all react related fixable issues
Syed-Ali-Abbas-Zaidi May 4, 2023
0d00d2d
fix: autofixable eslint issues
Syed-Ali-Abbas-Zaidi May 5, 2023
0f5078e
chore: remove all template literals
Syed-Ali-Abbas-Zaidi May 10, 2023
adc4621
fix: remaining autofixable issues
Syed-Ali-Abbas-Zaidi May 10, 2023
4d05181
chore: apply amnesty on all existing issues
Syed-Ali-Abbas-Zaidi May 5, 2023
b15f474
fix: failing xss-lint issues
Syed-Ali-Abbas-Zaidi May 5, 2023
f0da55c
refactor: apply amnesty on remaining issues
Syed-Ali-Abbas-Zaidi May 10, 2023
497875d
Merge branch 'master' of github.com:openedx/edx-platform into Ali-Abb…
Syed-Ali-Abbas-Zaidi May 18, 2023
b7955cc
refactor: apply amnesty on new issues
Syed-Ali-Abbas-Zaidi May 18, 2023
bf40b45
Merge branch 'master' into Ali-Abbas/eslint-amnesty
Syed-Ali-Abbas-Zaidi May 22, 2023
6eb5cc4
fix: remove file level suppressions
Syed-Ali-Abbas-Zaidi Aug 2, 2023
1f88360
Merge branch 'master' of github.com:openedx/edx-platform into Ali-Abb…
Syed-Ali-Abbas-Zaidi Aug 2, 2023
53f5c03
refactor: apply amnesty on new issues
Syed-Ali-Abbas-Zaidi Aug 2, 2023
70b8191
Merge branch 'master' of github.com:openedx/edx-platform into Ali-Abb…
Syed-Ali-Abbas-Zaidi Aug 7, 2023
8f593bb
Merge branch 'master' into Ali-Abbas/eslint-amnesty
Syed-Ali-Abbas-Zaidi Aug 7, 2023
7515d08
Merge branch 'master' into Ali-Abbas/eslint-amnesty
Syed-Ali-Abbas-Zaidi Aug 7, 2023
b60d93c
Merge branch 'master' into Ali-Abbas/eslint-amnesty
Syed-Ali-Abbas-Zaidi Aug 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: eslint operator-linebreak issue
  • Loading branch information
Syed-Ali-Abbas-Zaidi committed May 11, 2023
commit 148ca9bcfd5240cac9da3d6fe6eee5c0dca2eede
16 changes: 8 additions & 8 deletions lms/static/js/dashboard/legacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,12 @@ var edx = edx || {};
// xss-lint: disable=javascript-jquery-append
$('#activate-account-modal p').append(
// xss-lint: disable=javascript-concat-html
'<svg style="vertical-align:bottom" width="20" height="20"' +
'<svg style="vertical-align:bottom" width="20" height="20"'
// xss-lint: disable=javascript-concat-html
'viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">\n' +
+ 'viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">\n'
// xss-lint: disable=javascript-concat-html
'<path d="M9 16.2L4.8 12l-1.4 1.4L9 19 21 7l-1.4-1.4L9 16.2z" fill="#178253"/>\n' +
'</svg>'
+ '<path d="M9 16.2L4.8 12l-1.4 1.4L9 19 21 7l-1.4-1.4L9 16.2z" fill="#178253"/>\n'
+ '</svg>'
);
}, 500); // adding timeout to make spinner animation longer
}
Expand All @@ -254,12 +254,12 @@ var edx = edx || {};
// xss-lint: disable=javascript-jquery-append
$('#activate-account-modal p').append(
// xss-lint: disable=javascript-concat-html
'<svg class="fa-pulse" style="vertical-align:bottom" width="20" height="20"' +
'<svg class="fa-pulse" style="vertical-align:bottom" width="20" height="20"'
// xss-lint: disable=javascript-concat-html
'viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">\n' +
+ 'viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">\n'
// xss-lint: disable=javascript-concat-html
'<path d="M22 12A10 10 0 116.122 3.91l1.176 1.618A8 8 0 1020 12h2z" fill="#6c757d"/>\n' +
'</svg>'
+ '<path d="M22 12A10 10 0 116.122 3.91l1.176 1.618A8 8 0 1020 12h2z" fill="#6c757d"/>\n'
+ '</svg>'
);
});

Expand Down
1 change: 0 additions & 1 deletion xmodule/js/src/capa/display.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

(function() {
'use strict';

var indexOfHelper = [].indexOf
|| function(item) {
var i, len;
Expand Down