-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use event producer config #32874
Conversation
Replace openedx_event signal handlers with new producer config to push to event bus
cc6b931
to
b46d149
Compare
@@ -905,7 +905,7 @@ openedx-django-require==2.1.0 | |||
# via -r requirements/edx/base.txt | |||
openedx-django-wiki==2.0.0 | |||
# via -r requirements/edx/base.txt | |||
openedx-events==8.3.0 | |||
openedx-events @ git+https://github.com/open-craft/openedx-events@navin/configurable-handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update this requirement once openedx/openedx-events#249 is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navinkarkera 👍 LGTM. Good to see some code go away :)
- I tested this: Followed the testing instructions and verified that the events are getting published as per the configuration
- I read through the code
- I checked for accessibility issues
- Includes documentation - inline docs present
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @navinkarkera! Flagging the new tests per the recent update: https://discuss.openedx.org/t/minor-change-to-edx-platform-check-statuses/11131 |
@navinkarkera how would we feel about leaving events disabled by default until we figure out openedx/openedx-events#265 ? |
@rgraber Sure, feel free to create a new PR with the commits or however you see fit. |
I got git into a weird state and ended up just opening another PR here: #33269 . The only things that changed were openedx-events was set to 8.6.0 rather than a branch and all events start disabled in common.py |
@navinkarkera Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@navinkarkera Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Replace openedx_event signal handlers with new producer config to push to event bus.
Supporting information
Testing instructions
make {lms,cms}-up
make cms-shell
pip install -r requirements/edx/development.txt
to install new openedx_events version.make cms-logs
.EVENT_BUS_PRODUCER_CONFIG
by toggling the flag and triggering the event.Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.