-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install atlas
translations tool
#32952
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
a551f3c
to
b848ce1
Compare
I think we should hold off on this until we implement openedx/openedx-atlas#34 |
fb2be59
to
1d8649d
Compare
1d8649d
to
d684592
Compare
atlas
in Dockerfileatlas
CLI tool
d684592
to
c14529e
Compare
atlas
CLI toolatlas
translations tool
@brian-smith-tcril This is now ready for another review. |
@openedx/teaching-and-learning you're listed as "Review required from:" for this repo on the OEP-58/FC-12 repo reviewers spreadsheet. Would you mind taking a look at this one? |
c14529e
to
3c1b3d2
Compare
@jristau1984 @jmbowman I'm tagging you because you're listed as "Review required from:" for this repo on the FC-0012/OEP-58 spreadsheet |
3c1b3d2
to
dde1caf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of @jmbowman's team. I'm looking forward to translations being handled outside of Jenkins. Thank you.
@OmarIthawi @brian-smith-tcril: I know I just approved this, but I realize I do have a question. Is atlas actually needed in Production? Does it provide a potential security risk being a production dependency, rather than using another requirement file that can be used only where it is needed? |
@robrap Good question. My thinking is it's safe to have in production. Atlas is a bash script that is calls It has no server component, requirements or even a functional Python module. It's published on PyPi to make use of Docker-based environments may benefit from deleting it but there's a very small benefit from doing so.
You're welcome 😃 |
Add the openedx-atlas to the kernel.in so it's available in all environments including Atlas, Devstack and Native installation.
dde1caf
to
41e04ff
Compare
@brian-smith-tcril @robrap would you mind merging this pull request? It's been tested and reviewed. cc: @mphilbrick211 |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Add the openedx-atlas to the kernel.in so it's available in all environments including Atlas, Devstack and Native installation.
This is part 1 out of several other steps to eventually let
make pull_translations
pull from https://github.com/openedx/openedx-translations instead of Transifex, which has been concluded by OEP-58.This has been generated with the following command:
Which is inspired by the upgrade-one-python-dependency.yml workflow which I suppose I cannot run due to the lack of GitHub permission.
Testing instructions
openedx-atlas==0.5.0
edx-platform
Testing atlas pull with --expand-glob
Supporting information
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositories