feat: support V2 libraries in LibraryContentBlock (randomized only) #33258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than implementing V2-library and static-library-reference support in a new block, we will be enhancing the existing `LibraryContentBlock` in-place. Relevant ADR PR: openedx#33231
connorhaugh
reviewed
Sep 14, 2023
| @@ -471,6 +471,11 @@ def public_view(self, context): | |||
| return self._student_or_public_view(context or {}, prereq_met, prereq_meta_info, None, PUBLIC_VIEW) | |||
|
|
|||
| def author_view(self, context): # lint-amnesty, pylint: disable=missing-function-docstring | |||
| print('@@@@@@@@@@@@@@@@@@@@@@@@@@@') | |||
There was a problem hiding this comment.
Nit: remind myself to get rid of this
|
Closed in favor of #33263, which has a branch in the upstream repo so @connorhaugh can push to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author credit to @connorhaugh and RaccoonGang. I just did the rebase and squash.
This also contains the commit from:
To see just the new changes, see the second commit.