Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix studio for users with derived roles and some other related changes [BB-7834] #33275

Merged

Conversation

0x29a
Copy link
Contributor

@0x29a 0x29a commented Sep 18, 2023

Description

There are three commits serving different purposes:

Testing instructions

This needs mainly proofreading and regression testing:

  1. As a user with Course Staff role check that you see your own course in Studio and that no views from the Instructor Dashboard are throwing errors.
  2. Run this in the LMS shell:
from common.djangoapps.student.roles import strict_role_checking, ACCESS_ROLES_INHERITANCE
with strict_role_checking():
    print(ACCESS_ROLES_INHERITANCE)
print(ACCESS_ROLES_INHERITANCE)

You should get this output:

{}
{'staff': {'limited_staff'}}

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 18, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@gabor-boros gabor-boros force-pushed the 0x29a/bb7834/inherited-roles-studio-fix branch from a04ffae to 7600032 Compare October 1, 2023 07:36
@Agrendalath Agrendalath force-pushed the 0x29a/bb7834/inherited-roles-studio-fix branch from 7600032 to 5b34e08 Compare October 16, 2023 13:44
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x29a, one request - please add a comment to the context manager to explain why it's here and what it can do in the plugins.

👍

  • I tested this: checked the access role inheritance behaves correctly (except for the issues fixed in fix: limited staff cohorts and gradebook access [BB-7962] #33491)
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@0x29a 0x29a force-pushed the 0x29a/bb7834/inherited-roles-studio-fix branch from 5b34e08 to 9e56a18 Compare October 16, 2023 18:06
@Agrendalath Agrendalath merged commit 6b082c7 into openedx:master Oct 16, 2023
60 checks passed
@Agrendalath Agrendalath deleted the 0x29a/bb7834/inherited-roles-studio-fix branch October 16, 2023 19:16
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@openedx-webhooks
Copy link

@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants