Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [FC-0031] Add Bearer Authentication to Delete Account view #33289

Merged
merged 3 commits into from
Sep 26, 2023
Merged

feat: [FC-0031] Add Bearer Authentication to Delete Account view #33289

merged 3 commits into from
Sep 26, 2023

Conversation

oksana-slu
Copy link
Contributor

Description

As mobile apps are using bearer token auth, the BearerAuthentication class authentication_classes for this API View was added. This view is used in the mobile account settings, to allow user deactivate (delete) their account from the system.

Supporting information

Part of the project FC-0031 https://openedx.atlassian.net/wiki/spaces/COMM/pages/3844505604/FC-0031+-+Mobile+API+Migration

Testing instructions

Send POST /api/user/v1/accounts/deactivate/ with Bearer Token instead of JWT

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 20, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @oksana-slu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@GlugovGrGlib GlugovGrGlib force-pushed the rg/feat/FC0031/add_bearer_authorization_in_delete_user_api branch from fe9ee46 to 4c50ad0 Compare September 22, 2023 09:07
@e0d e0d requested a review from feanil September 22, 2023 19:32
feanil
feanil approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, one suggested comment, is there a github issue we can point to in the comment so we know when to clean this up?

openedx/core/djangoapps/user_api/accounts/views.py Show resolved Hide resolved
@feanil
Copy link
Contributor

feanil commented Sep 25, 2023

It looks like this is ready to go, I'll merge it tomorrow morning (EDT) so I can keep an eye on it going out.

@feanil feanil merged commit 437b7e6 into openedx:master Sep 26, 2023
60 checks passed
@openedx-webhooks
Copy link

@oksana-slu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@oksana-slu oksana-slu deleted the rg/feat/FC0031/add_bearer_authorization_in_delete_user_api branch September 26, 2023 11:59
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@marcotuts marcotuts mentioned this pull request Sep 27, 2023
Closed
@OmarIthawi OmarIthawi mentioned this pull request May 31, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyryloKireiev KyryloKireiev KyryloKireiev left review comments

@GlugovGrGlib GlugovGrGlib GlugovGrGlib approved these changes

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Open edX Mobile Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oksana-slu @openedx-webhooks @feanil @edx-pipeline-bot @GlugovGrGlib @KyryloKireiev