Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emit signal for thread created event #33374

Closed
wants to merge 1 commit into from
Closed

feat: emit signal for thread created event #33374

wants to merge 1 commit into from

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Sep 28, 2023 •
edited
Loading

Description

This PR emits an Open edX signal for forum events.

The signals are specified in the following PR: openedx/openedx-events#273

Dependencies

This PR depends on openedx/openedx-events#273

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 28, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 28, 2023 •
edited
Loading

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 mentioned this pull request Sep 28, 2023
Merged
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-created-event branch from 117af43 to 6512988 Compare September 28, 2023 22:25
@Ian2012 Ian2012 mentioned this pull request Sep 29, 2023
Merged
7 tasks
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-created-event branch from 6512988 to 183bea3 Compare September 29, 2023 16:31
@Ian2012 Ian2012 marked this pull request as ready for review September 29, 2023 18:46
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-created-event branch 2 times, most recently from 0a0adde to 687720c Compare October 2, 2023 16:41
@ashultz0 @Ian2012
Merge pull request openedx#33371 from openedx/ashultz0/emphasize-most…
5acde7c 
…-important-test-instruction

docs: actually pull the eye to the most weird and critical instruction
@Ian2012 Ian2012 closed this Oct 2, 2023
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-created-event branch from 687720c to 5acde7c Compare October 2, 2023 22:11
@Ian2012 Ian2012 requested a review from a team as a code owner October 2, 2023 22:11
@openedx-webhooks
Copy link

@Ian2012 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@Ian2012 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ian2012 @openedx-webhooks @ashultz0