Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace py2neo with forked package #33453

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix: replace py2neo with forked package #33453

merged 5 commits into from
Oct 10, 2023

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Oct 10, 2023 •
edited
Loading

Description

  • py2neo official PyPI and GitHub packages have been removed.
  • Using the most recent fork (2021.2.dev0) instead of the required master (2021.2.3) version
  • This fork will be temporarily used to resolve the blocker for now
  • A follow up issue Replace py2neo fork with official Neo4j driver #33456 has been created to remove the usage of this fork later on.

@UsamaSadiq UsamaSadiq requested a review from a team as a code owner October 10, 2023 10:16
@UsamaSadiq UsamaSadiq force-pushed the replace-py2neo-with-py2neo-fork branch from 19ffad5 to 96cfe33 Compare October 10, 2023 10:20
@UsamaSadiq UsamaSadiq mentioned this pull request Oct 10, 2023
Closed
@UsamaSadiq UsamaSadiq changed the title test: test using py2neo fork commit fix: replace py2neo with forked package Oct 10, 2023
iamsobanjaved
iamsobanjaved approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found the latest possible fork, but still, this is downgrading py2neo to 2021.2.dev0 from 2021.2.3. Merging this now to unblock the build, will shift to the official python driver.

@UsamaSadiq UsamaSadiq requested a review from jmbowman October 10, 2023 11:53
@cmltaWt0
Copy link
Contributor

cmltaWt0 commented Oct 10, 2023 •
edited
Loading

We found the latest possible fork, but still, this is downgrading py2neo to 2021.2.dev0 from 2021.2.3. Merging this now to unblock the build, will shift to the official python driver.

@UsamaSadiq @iamsobanjaved
Maybe we should consider using @regisb fork for 2021.2.3 version here?
https://github.com/overhangio/py2neo/tree/2021.2.3

@UsamaSadiq
Copy link
Member Author

We found the latest possible fork, but still, this is downgrading py2neo to 2021.2.dev0 from 2021.2.3. Merging this now to unblock the build, will shift to the official python driver.

@UsamaSadiq @iamsobanjaved Maybe we should consider using @regisb fork for 2021.2.3 version here? https://github.com/overhangio/py2neo/tree/2021.2.3

Let me update the fork url to use the suggested fork instead.

@UsamaSadiq UsamaSadiq merged commit 1db6867 into master Oct 10, 2023
61 checks passed
@UsamaSadiq UsamaSadiq deleted the replace-py2neo-with-py2neo-fork branch October 10, 2023 13:29
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@cmltaWt0 cmltaWt0 mentioned this pull request Oct 10, 2023
Merged
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

cmltaWt0 pushed a commit to raccoongang/edx-platform that referenced this pull request Oct 10, 2023
@UsamaSadiq @cmltaWt0
fix: replace py2neo with forked package (openedx#33453)
4793b8e 
* fix: replace py2neo with overhangio py2neo fork
timmc-edx pushed a commit that referenced this pull request Oct 10, 2023
@cmltaWt0 @UsamaSadiq
fix: replace py2neo with forked package (#33453) (#33459)
176d0d8 
Co-authored-by: Usama Sadiq <[email protected]>
@dyudyunov dyudyunov mentioned this pull request Oct 11, 2023
Merged
ahmed-arb pushed a commit to wikimedia/edx-platform that referenced this pull request Oct 17, 2023
@cmltaWt0 @UsamaSadiq @ahmed-arb
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
2d8735b 
Co-authored-by: Usama Sadiq <[email protected]>
ahmed-arb added a commit to wikimedia/edx-platform that referenced this pull request Oct 17, 2023
@ahmed-arb @cmltaWt0 @UsamaSadiq
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)…
2779e3d 
… (#365)

Co-authored-by: Max Sokolski <[email protected]>
Co-authored-by: Usama Sadiq <[email protected]>
@andrey-canon andrey-canon mentioned this pull request Oct 20, 2023
Merged
becdavid added a commit to CUCWD/edx-platform that referenced this pull request Dec 11, 2023
@becdavid @UsamaSadiq
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
958b99b 
Co-authored-by: Usama Sadiq <[email protected]>
shURenZHOUluxun pushed a commit to EduTrigger/edx-platform that referenced this pull request Jan 3, 2024
@cmltaWt0 @UsamaSadiq @shURenZHOUluxun
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
46da449 
Co-authored-by: Usama Sadiq <[email protected]>
johanseto pushed a commit to nelc/edx-platform that referenced this pull request Jan 22, 2024
@UsamaSadiq @andrey-canon
fix: replace py2neo with forked package (openedx#33453)
d341bf6 
* fix: replace py2neo with overhangio py2neo fork
johanseto pushed a commit to nelc/edx-platform that referenced this pull request Jan 22, 2024
@andrey-canon
Merge pull request openedx#784 from eduNEXT/and/py2neo_fix
6427bbf 
fix: replace py2neo with forked package (openedx#33453)
ztraboo added a commit to CUCWD/edx-platform that referenced this pull request Apr 12, 2024
@ztraboo @UsamaSadiq
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
ccfadf5 
Co-authored-by: Usama Sadiq <[email protected]>
a-kryachko pushed a commit to raccoongang/edx-platform that referenced this pull request Jun 14, 2024
@cmltaWt0 @UsamaSadiq @a-kryachko
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
22ce273 
Co-authored-by: Usama Sadiq <[email protected]>
@OmarIthawi OmarIthawi mentioned this pull request Jul 24, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

@jmbowman jmbowman jmbowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@UsamaSadiq @cmltaWt0 @edx-pipeline-bot @jmbowman @iamsobanjaved @edx-requirements-bot