-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to send email to cherry-picked students #33463
feat: add support to send email to cherry-picked students #33463
Conversation
Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
b6585be
to
2614192
Compare
2614192
to
8668276
Compare
I'll re-try running tests later since they're failing because of the runner: https://github.com/openedx/edx-platform/actions/runs/6482279061 |
Hi @mariajgrimaldi - just checking in on this :) |
I'll close this PR since we're not pursuing this implementation anymore. |
@mariajgrimaldi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR supports sending emails to a list of students submitted by the course instructor via the communications MFE:
Screencast.from.10-10-23.15.46.48.webm
This PR depends on the implementation in this communications MFE PR.
Design overview
The following happens when sending emails with the Bulk Email feature in the Instructor dashboard:
instructor/api/send_email
implemented by the send_email viewInstructorTaskTypes.BULK_COURSE_EMAIL
task is executed, which under the hood calls forperform_delegate_email_batches
task.So, for this feature, we needed to:
perform_delegate_email_batches
: when emails are submitted in the MFE new field, the targetindividual-learners
we created before is used. When using this target, the Course Email method to retrieve recipients returns a list of users filtered by the list of emails we sent before.Supporting information
Open edX Platform roadmap issue, which this PR partially solves: openedx/platform-roadmap#254
Testing instructions
I use tutor stack and npm start for better MFE development, so I'll describe how I'm currently using it. You can use devstack if it's easier for you.
npm i && npm run start
Turn on the bulk email flag globally:
Turn on the bulk email new experience:
FEATURES['ENABLE_NEW_BULK_EMAIL_EXPERIENCE'] = True
, you can add it too to your tutor plugin.Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
More docs on bulk email: https://edx.readthedocs.io/projects/open-edx-building-and-running-a-course/en/named-release-birch/running_course/bulk_email.html
Aditional thoughts
As I mentioned, this PR needs to be reviewed alongside the PR in the MFE. Also, I wish there was a better way of including new targets to bulk emails without running database migrations, so we're open to suggestions for a more extensible solution.