feat: remove manual sends of events #33642
Conversation
rgraber
force-pushed
the
rsgraber/20231031-publish-via-config-contract
branch
from
0e7e29d to
34bfa5a
Compare
| """ | ||
| Handlers for student | ||
| """ |
There was a problem hiding this comment.
Everything looks good except I'm confused about where this module was ever getting loaded from!
There was a problem hiding this comment.
I actually could never get this code to work which may be because it wasn't hooked up to anything ><
There was a problem hiding this comment.
https://github.com/search?q=repo%3Aopenedx%2Fedx-platform%20%22common.djangoapps.student.handlers%22&type=code It doesn't seem to have been called anywhere except its own tests
There was a problem hiding this comment.
Haha, I was wondering if this was the same event that was giving you trouble! There's no code reference to "handlers" anywhere in common/djangoapps/student/ and it looks like all the other apps load their signal receivers from their ready method (rather than from some hypothetical non-local mechanism).
@kiram15 It looks like this code was never hooked up to send to the event bus. I don't see any log entries for "Producing unenrollment-event event via" either, which is pretty good confirmation.
However...I do see log entries for "Responses of the Open edX Event <org.openedx.learning.course.unenrollment.completed.v1>" source="/edx/var/log/lms/edx.log" pretty steadily over the past month. So... something was sending it to the event bus!
There was a problem hiding this comment.
Not necessarily. Those are the logs we get for local signal sends
There was a problem hiding this comment.
Ah right, thanks! Searching for the topic is more appropriate... and I only find the stage-prefixed topic, not the production one. So that checks out.
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Remove manual sends to the event bus now that EVENT_BUS_PRODUCER_CONFIG has been rolled out. Enables the events that were previously enabled in devstack via the config.
Supporting information
edx/edx-arch-experiments#381