Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: checking python 3.9. #33744

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-consistent-dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- uses: actions/setup-python@v4
if: ${{ env.RELEVANT == 'true' }}
with:
python-version: '3.8'
python-version: '3.9'

- name: "Recompile requirements"
if: ${{ env.RELEVANT == 'true' }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-for-tutorial-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:
jobs:
# Provide helpful bot comment
comment:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
name: provide helpful bot comment
steps:
- name: Checkout
Expand All @@ -32,4 +32,4 @@ jobs:
Thank you for your pull request! Congratulations on completing the Open edX tutorial! A team member will be by to take a look shortly.
To those watching community pull requests: No need to worry about this one, a tCRIL team member will be taking care of it.
For this PR's author: If this is a PR that is NOT coming from the Open edX tutorial, please comment and let us know to disregard this message.
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/ci-static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ['3.8']
python-version: ['3.9']
os: ['ubuntu-20.04']

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compile-python-requirements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Set up Python environment
uses: actions/setup-python@v4
with:
python-version: "3.8"
python-version: "3.9"

- name: Run make compile-requirements
env:
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ jobs:
# Push image to GitHub Packages.
# See also https://docs.docker.com/docker-hub/builds/
push:
runs-on: ubuntu-latest
if: github.event_name == 'push'
runs-on: ubuntu-20.04
if: github.event_name == 'push'

strategy:
matrix:
variant:
Expand Down Expand Up @@ -38,6 +38,5 @@ jobs:
- name: Build and push lms base docker image
env:
DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
run : make docker_tag_build_push_${{matrix.variant}}

2 changes: 1 addition & 1 deletion .github/workflows/js-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
matrix:
os: [ ubuntu-20.04 ]
node-version: [ 16 ]
python-version: [ 3.8 ]
python-version: [ "3.9" ]

steps:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-imports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.9'

- name: Install system requirements
run: sudo apt update && sudo apt install -y libxmlsec1-dev
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/migrations-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-20.04 ]
python-version: [ 3.8 ]
python-version: [ '3.9' ]
# 'pinned' is used to install the latest patch version of Django
# within the global constraint i.e. Django==4.2.8 in current case
# because we have global constraint of Django<4.2
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
./manage.py lms migrate
echo "Running the CMS migrations."
./manage.py cms migrate

# This job aggregates test results. It's the required check for branch protection.
# https://github.com/marketplace/actions/alls-green#why
# https://github.com/orgs/community/discussions/33579
Expand All @@ -124,7 +124,7 @@ jobs:
if: always()
needs:
- check_migrations
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Decide whether the needed jobs succeeded or failed
# uses: re-actors/[email protected]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pylint-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: "3.9"

- name: Get pip cache dir
id: pip-cache-dir
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
if: always()
needs:
- run-pylint
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Decide whether the needed jobs succeeded or failed
# uses: re-actors/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/quality-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-20.04 ]
python-version: [ 3.8 ]
python-version: [ "3.9" ]
node-version: [ 16 ]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/semgrep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
os: [ "ubuntu-20.04" ]
python-version: [ "3.8" ]
python-version: [ "3.9" ]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static-assets-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-20.04 ]
python-version: [ 3.8 ]
python-version: [ "3.9" ]
node-version: [ 16 ]
npm-version: [ 8.5.x ]

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests-gh-hosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ '3.8' ]
python-version: [ '3.9' ]
django-version:
- "pinned"
# When updating the shards, remember to make the same changes in
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [ '3.8' ]
python-version: [ '3.9' ]
django-version:
- "pinned"
steps:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
python-version:
- "3.8"
- "3.9"
django-version:
- "pinned"
# When updating the shards, remember to make the same changes in
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
if: (github.repository == 'edx/edx-platform-private') || (github.repository == 'openedx/edx-platform' && (startsWith(github.base_ref, 'open-release') == false))
needs:
- run-tests
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Decide whether the needed jobs succeeded or failed
# uses: re-actors/[email protected]
Expand Down Expand Up @@ -124,10 +124,10 @@ jobs:
# Combine and upload coverage reports.
coverage:
needs: run-tests
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [ 3.8 ]
python-version: [ "3.9" ]
steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upgrade-one-python-dependency.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Set up Python environment
uses: actions/setup-python@v4
with:
python-version: "3.8"
python-version: "3.9"

- name: Update any pinned dependencies
env:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/upgrade-python-requirements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
team_reviewers: "arbi-bom"
email_address: [email protected]
send_success_notification: false
python_version: '3.9'
secrets:
requirements_bot_github_token: ${{ secrets.REQUIREMENTS_BOT_GITHUB_TOKEN }}
requirements_bot_github_email: ${{ secrets.REQUIREMENTS_BOT_GITHUB_EMAIL }}
Expand Down
11 changes: 4 additions & 7 deletions requirements/edx-sandbox/py38.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# make upgrade
Expand All @@ -14,7 +14,7 @@ click==8.1.6
# nltk
codejail-includes==1.0.0
# via -r requirements/edx-sandbox/py38.in
contourpy==1.1.1
contourpy==1.2.0
# via matplotlib
cryptography==38.0.4
# via
Expand All @@ -23,7 +23,6 @@ cryptography==38.0.4
cycler==0.12.1
# via matplotlib
fonttools==4.47.2
# via matplotlib
importlib-resources==6.1.1
# via matplotlib
joblib==1.3.2
Expand All @@ -39,11 +38,11 @@ markupsafe==2.1.4
# via
# chem
# openedx-calc
matplotlib==3.7.4
matplotlib==3.8.2
# via -r requirements/edx-sandbox/py38.in
mpmath==1.3.0
# via sympy
networkx==3.1
networkx==3.2.1
# via -r requirements/edx-sandbox/py38.in
nltk==3.8.1
# via
Expand Down Expand Up @@ -93,5 +92,3 @@ sympy==1.12
# openedx-calc
tqdm==4.66.1
# via nltk
zipp==3.17.0
# via importlib-resources
2 changes: 1 addition & 1 deletion requirements/edx/assets.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# make upgrade
Expand Down
1 change: 1 addition & 0 deletions requirements/edx/base.in
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
-r kernel.in # Core dependencies required for the platform to run.
-r bundled.in # Additional packages usually bundled with the platform
backports.zoneinfo;python_version<"3.9"
13 changes: 2 additions & 11 deletions requirements/edx/base.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# make upgrade
Expand Down Expand Up @@ -312,7 +312,7 @@ django-model-utils==4.3.1
# edxval
# ora2
# super-csv
django-mptt==0.14.0
django-mptt==0.15.0
# via
# -r requirements/edx/kernel.in
# openedx-django-wiki
Expand Down Expand Up @@ -829,8 +829,6 @@ pillow==10.2.0
# edx-enterprise
# edx-organizations
# edxval
pkgutil-resolve-name==1.3.10
# via jsonschema
platformdirs==3.11.0
# via snowflake-connector-python
polib==1.2.0
Expand Down Expand Up @@ -1140,9 +1138,7 @@ typing-extensions==4.9.0
# -r requirements/edx/paver.txt
# asgiref
# django-countries
# drf-spectacular
# edx-opaque-keys
# kombu
# pylti1p3
# snowflake-connector-python
tzdata==2023.4
Expand All @@ -1166,7 +1162,6 @@ urllib3==1.26.18
# elasticsearch
# py2neo
# requests
# snowflake-connector-python
user-util==1.0.0
# via -r requirements/edx/kernel.in
vine==5.1.0
Expand Down Expand Up @@ -1233,10 +1228,6 @@ xss-utils==0.5.0
# via -r requirements/edx/kernel.in
yarl==1.9.4
# via aiohttp
zipp==3.17.0
# via
# importlib-metadata
# importlib-resources

# The following packages are considered to be unsafe in a requirements file:
# setuptools
2 changes: 1 addition & 1 deletion requirements/edx/coverage.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# make upgrade
Expand Down
Loading
Loading