Fix ObjectTag taxonomy rule [FC-0036] #33757
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
pomegranited
changed the title
|
Sandbox deploy request received. Deployment will start soon. |
|
Sandbox deployment started. |
|
Sandbox deployment failed. Check failure logs here https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5582826732.log Please check the settings and requirements and retry deployment by updating the pull request or posting a |
There was a problem hiding this comment.
@pomegranited Looks good 👍
- I tested this: I followed the testing instructions with a unit
- I read through the code and considered the security, stability and performance implications of the changes.
- [n/a] I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
- Includes documentation
- [n/a] Includes fixtures that create objects required for manual testing.
|
@pomegranited I updated the branch to temporarily use it in the sandbox. |
|
Sandbox update request received. Deployment will start soon. |
|
Sandbox deployment started. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33757-139931.staging.do.opencraft.hosting |
|
Sandbox update request received. Deployment will start soon. |
|
Sandbox deployment started. |
pomegranited
force-pushed
the
jill/fix-objecttag-rule
branch
from
882a5ae to
42c0c2e
Compare
|
Sandbox update request received. Deployment will start soon. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33757-139931.staging.do.opencraft.hosting |
|
Sandbox deployment started. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33757-139931.staging.do.opencraft.hosting |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
bradenmacdonald
force-pushed
the
jill/fix-objecttag-rule
branch
from
42c0c2e to
108b7c0
Compare
|
@pomegranited Some GitHub issues are affecting this PR. I was planning to merge it today but I'll have to try tomorrow instead. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33757-139931.staging.do.opencraft.hosting Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5627693371-config.yml |
|
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Sandbox destroy request received. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
There is a bug in the ObjectTag rules which appears when the REST API tries to fetch all ObjectTags for a given object_id (without limiting to a specific taxonomy). This PR illustrates the issue by adding a test which fails, and then fixes it by fixing the rule.
Supporting information
Relates to openedx/modular-learning#118
Testing instructions
This change is covered by tests, but to test manually:
new_studio_mfe.use_tagging_taxonomy_list_pagestaffaccount (can't use a superuser; superusers bypass permissions rule checks).Deadline
None
Other information
Private-ref: FAL-3530