feat: add new course access error_code for enterprise learners in future courses #33913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
commented
Dec 11, 2023
| Arguments: | ||
| display_error_to_user: If True, display this error to users in the UI. | ||
| """ | ||
| error_code = "course_not_started_enterprise_learner" |
There was a problem hiding this comment.
here's the error_code to match up in the case statement on the frontend.
macdiesel
reviewed
Dec 12, 2023
pwnage101
force-pushed
the
pwnage101/ENT-8078
branch
2 times, most recently
from
436dbeb to
67ef00d
Compare
pwnage101
changed the title
pwnage101
force-pushed
the
pwnage101/ENT-8078
branch
3 times, most recently
from
8cc79fb to
c417aa8
Compare
pwnage101
force-pushed
the
pwnage101/ENT-8078
branch
3 times, most recently
from
d0aa6b3 to
583a56b
Compare
…ure courses
Normally, the course API would return an access error_code of
`course_not_started` if the course has not started yet. This change
breaks that up into two codes:
* if the course has not started:
* return error_code=`course_not_started_enterprise_learner` if the
learner is enrolled as a subsidized enterprise learner.
* else, return error_code=`course_not_started`.
This supports a change to the frontend which will interpret
`course_not_started_enterprise_learner` differently and trigger a
redirect to the enterprise (B2B) learner dashboard instead of the B2C
dashboard.
ENT-8078
pwnage101
force-pushed
the
pwnage101/ENT-8078
branch
from
583a56b to
287a7ff
Compare
|
I just incorporated
|
pwnage101
commented
Dec 15, 2023
| @@ -75,6 +76,7 @@ def check_start_date(user, days_early_for_beta, start, course_key, display_error | |||
| Returns: | |||
| AccessResponse: Either ACCESS_GRANTED or StartDateError. | |||
| """ | |||
| from openedx.features.enterprise_support.api import enterprise_customer_from_session_or_learner_data | |||
There was a problem hiding this comment.
Don't really understand what's going on here, but adding this at the top of the file caused a circular import error. This pattern is used elsewhere in this same file so I just copied it.
macdiesel
approved these changes
Dec 15, 2023
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normally, the course API would return an access error_code of
course_not_startedif the course has not started yet. This change breaks that up into two codes:course_not_started_enterprise_learnerif the learner is enrolled as a subsidized enterprise learner.course_not_started.This supports a change to the frontend which will interpret
course_not_started_enterprise_learnerdifferently and trigger a redirect to the enterprise (B2B) learner dashboard instead of the B2C dashboard.ENT-8078
Supporting information
Companion PR: openedx/frontend-app-learning#1251