-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Language auto tagging library blocks #34056
feat: Language auto tagging library blocks #34056
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
9436b16
to
c66d0bf
Compare
42e4470
to
20e1601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @yusuf-musleh! 👍
- I tested this using the Testing Instructions and the tag was correctly applied and removed from the library
- I read through the code
-
I checked for accessibility issues - Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
I just added a nit about the flag check order.
(I know that both of my comments ^ are about existing patterns that you just copied, but I'm wondering why it's like that, so I'd like to consider a simpler version rather than just copying it as-is). |
1f4be3b
to
a92a573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! I'll merge tomorrow
a92a573
to
71eb943
Compare
71eb943
to
be2dbb8
Compare
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR adds functionality of automatically tagging library blocks with a language tag when they created/update and automatically deletes them when they are deleted.
Supporting information
Related Tickets:
Testing instructions
content_tagging.auto
waffle flagmake cms-shell
):>>> from openedx_tagging.core.tagging.models import ObjectTag >>> ObjectTag.objects.all().count()
.last()
to see the newly created one.last()
is now longer what it was in the previous step.Private-ref: FAL-3497