Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add state sent to state column #34127

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

Alec4r
Copy link
Contributor

@Alec4r Alec4r commented Jan 26, 2024

Description

Adding a New State "Sent" to Reports

  • A new state, "Sent," has been added to the reports.
  • This state is applied to reports that have been successfully sent to Axim.
  • Previously, only the state "generated" was implemented which could be confusing and didn't confirm if the report was sent or not.

Notes

These changes were reverted in #34110, I have divided the changes in different PRs (#34126)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 26, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Alec4r! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Alec4r. This looks good to me.

Should we merge this before of after #34092?

@felipemontoya
Copy link
Member

@macdiesel this will bring back part of what was reverted in #34110. Specifically the part that was not in conflict with enterprise. The fix for jquery will come in another PR

@Alec4r
Copy link
Contributor Author

Alec4r commented Jan 26, 2024

thanks @Alec4r. This looks good to me.

Should we merge this before of after #34092?

Yes, we should merge:
1st - #34126
2nd - #34127
3rd - #34092

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works as expected. I tested it, and it should be fine with the enterprise because it is not touching jQuery.

References:
#34033
#34110

@felipemontoya felipemontoya merged commit 4b7ef26 into openedx:master Jan 30, 2024
64 checks passed
@openedx-webhooks
Copy link

@Alec4r 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Alec4r added a commit to eduNEXT/edx-platform that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants