Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add language and translation flag to courseware api #34309

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Feb 28, 2024

Description

  • add whole_course_translations_enabled flag and language fields to send to courseware api

Note:

Copy link
Contributor

@nsprenkle nsprenkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about nesting these fields? I can see this becoming messy if we keep adding lots of one-off fields to this serializer.

course_settings: {
    course_language = "en",
    whole_course_translations_enabled = True / False,
    ....
}

@leangseu-edx
Copy link
Contributor Author

How would you feel about nesting these fields? I can see this becoming messy if we keep adding lots of one-off fields to this serializer.

course_settings: {
    course_language = "en",
    whole_course_translations_enabled = True / False,
    ....
}

It is only 2 fields currently. I don't foresee it being more than this. It feel unnecessary.

@nsprenkle nsprenkle merged commit 662bff8 into nsprenkle/whole-course-translations-waffle Feb 29, 2024
46 checks passed
@nsprenkle nsprenkle deleted the lk/add-course-translation-flag-to-api branch February 29, 2024 20:34
nsprenkle added a commit that referenced this pull request Mar 4, 2024
* feat: add waffle flag for whole course translations

* feat: put ai translations behind waffle

* chore: add ai_translations to quality matrix

* chore: add language and translation flag to courseware api (#34309)

---------

Co-authored-by: Leangseu Kim <[email protected]>
nsprenkle added a commit that referenced this pull request Mar 19, 2024
* feat: add waffle flag for whole course translations

* feat: put ai translations behind waffle

* chore: add ai_translations to quality matrix

* chore: add language and translation flag to courseware api (#34309)

---------

Co-authored-by: Leangseu Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants