Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Remove Neo4J Support #34342 #34417

Merged
merged 1 commit into from
May 28, 2024

Conversation

qasimgulzar
Copy link
Contributor

Issue

Proposal Date: 2024-03-07
Target Ticket Acceptance Date: 2024-03-21
Earliest Open edX Named Release Without This Functionality: Sumac 2024-10

Rationale

This pull request addresses the removal of Neo4j support from the edx-platform, along with the associated dependencies and the coursegraph app. The decision to deprecate and remove this functionality stems from the observation that Neo4j usage is underused and not deemed particularly valuable, with many operators transitioning to alternative data stores for course data search.

Changes Made

  1. Removal of Neo4j dependencies.
  2. Removal of the coursegraph app from cms.djangpapps.coursegraph.

Replacement

There is currently no direct replacement proposed for the functionality being removed. However, users interested in retaining this functionality can explore creating a separate plugin.

Discussion Thread

Discuss thread

Solution Implementation

The solution involves removing the Neo4j dependencies and the coursegraph app from the specified location in the codebase.

Solution Implementation Details:

I have removed the neo4j dependencies as well as the course graph app from cms.djangpapps.coursegraph

@openedx-webhooks
Copy link

Thanks for the pull request, @qasimgulzar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 25, 2024
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 25, 2024
@qasimgulzar qasimgulzar force-pushed the qasim/DEPR/git-issue-34342 branch from d9dc34c to 752dc92 Compare March 26, 2024 06:25
@qasimgulzar qasimgulzar requested a review from a team as a code owner March 26, 2024 06:25
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 28, 2024
@mphilbrick211
Copy link

Hi @openedx/2u-vanguards! Are you able to take a look at this?

@awais786
Copy link
Contributor

@qasimgulzar for safe side you can split this PR into two parts. In first part remove the code and in 2nd PR remove the package.

@qasimgulzar qasimgulzar force-pushed the qasim/DEPR/git-issue-34342 branch from 650585e to c7399d1 Compare May 17, 2024 13:50
@qasimgulzar qasimgulzar force-pushed the qasim/DEPR/git-issue-34342 branch from c7399d1 to 48cdbce Compare May 17, 2024 13:56
@qasimgulzar
Copy link
Contributor Author

@qasimgulzar for safe side you can split this PR into two parts. In first part remove the code and in 2nd PR remove the package.

I would agree with your recommendation, so removed the requirement's changes for this PR.

@feanil
Copy link
Contributor

feanil commented May 20, 2024

Looks like 2U is still using this old infrastructure and so we should hold of till May 27, 2024 to merge this PR.

@feanil
Copy link
Contributor

feanil commented May 28, 2024

image

Merging a bit early since we've got the go ahead.

@feanil feanil merged commit 4085066 into openedx:master May 28, 2024
47 checks passed
@openedx-webhooks
Copy link

@qasimgulzar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants