-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: waffle refunds for commerce-coordinator #34438
Conversation
This edx-lint check is to prevent: import waffle However, we are doing: import .waffle Where .waffle is importing correctly from edx_toggles instead of directly from the Django waffle library. See also: https://github.com/openedx/edx-lint/blob/be07c3739d73cd44d33d9d9dbf5f3119a906be9e/edx_lint/pylint/annotations_check.py#L379
7de2c96
to
ed52704
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left an improvement comment, otherwise looks good 👍
Also, please ensure to add the waffle flag and new settings flag values for stage/prod environments.
Thanks for the pull request, @pshiu! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
Cant merge because of CLA. Rerolling PR |
@pshiu Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
# feat: waffle refunds for commerce-coordinator Based on approved: #34438 However CLA is invalid now for initial creator so a new PR was required.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
No description provided.