Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: waffle refunds for commerce-coordinator #34438

Closed

Conversation

pshiu
Copy link
Contributor

@pshiu pshiu commented Mar 27, 2024

No description provided.

@pshiu pshiu self-assigned this Mar 27, 2024
pshiu added 3 commits April 2, 2024 04:53
This edx-lint check is to prevent:

    import waffle

However, we are doing:

    import .waffle

Where .waffle is importing correctly from edx_toggles instead of
directly from the Django waffle library.

See also:

https://github.com/openedx/edx-lint/blob/be07c3739d73cd44d33d9d9dbf5f3119a906be9e/edx_lint/pylint/annotations_check.py#L379
@pshiu pshiu force-pushed the pshiu/SONIC-382_LmsRedirectsRefundsToCoordinator branch from 7de2c96 to ed52704 Compare April 2, 2024 08:53
lms/djangoapps/commerce/utils.py Show resolved Hide resolved
lms/envs/common.py Show resolved Hide resolved
@grmartin grmartin requested a review from shafqatfarhan April 8, 2024 14:32
@grmartin grmartin self-assigned this Apr 8, 2024
@shafqatfarhan shafqatfarhan marked this pull request as ready for review April 8, 2024 17:29
Copy link
Contributor

@shafqatfarhan shafqatfarhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an improvement comment, otherwise looks good 👍

Also, please ensure to add the waffle flag and new settings flag values for stage/prod environments.

lms/djangoapps/commerce/utils.py Outdated Show resolved Hide resolved
lms/djangoapps/commerce/utils.py Outdated Show resolved Hide resolved
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2024
@openedx openedx deleted a comment from openedx-webhooks Apr 9, 2024
@openedx openedx deleted a comment from openedx-webhooks Apr 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @pshiu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@grmartin
Copy link
Contributor

Cant merge because of CLA. Rerolling PR

@openedx-webhooks
Copy link

@pshiu Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

grmartin added a commit that referenced this pull request Apr 12, 2024
# feat: waffle refunds for commerce-coordinator

Based on approved: #34438

However CLA is invalid now for initial creator so a new PR was required.
@grmartin grmartin deleted the pshiu/SONIC-382_LmsRedirectsRefundsToCoordinator branch April 12, 2024 14:43
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants