Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0044] refactoring xblock actions #34452

Conversation

ruzniaievdm
Copy link
Contributor

@ruzniaievdm ruzniaievdm commented Mar 29, 2024

Description

Each xblock component’s three dots menu on the Unit Page has buttons that will initiate action with xblock.
After the investigation it was determined that the condition is_course is sufficient to enable/disable actions on each xblock. Currently any action from the FE does not contain a condition for reflection so in the next FE PR it will be covered.

image

Testing instructions

  1. Run master devstack.
  2. Start platform make dev.up.lms+cms and make checkout on this branch.
  3. Go to studio home page and choose the course.
  4. Create Unit from the subsection and open it.
  5. Copy location of the unit block.
  6. Go to http://localhost:18010/api-docs.
  7. Find the required API endpoint /api/contentstore/v1/container/vertical/{usage_key_string}/children.
  8. Get usage_key_string from previous step and paste it to required API endpoint to get actions data for unit.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 29, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ruzniaievdm! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ruzniaievdm ruzniaievdm force-pushed the ruzniaievdm/feat/refactoring-xblock-actions branch from fe21748 to 1e50218 Compare April 9, 2024 16:09
@GlugovGrGlib GlugovGrGlib force-pushed the ruzniaievdm/feat/refactoring-xblock-actions branch 2 times, most recently from 7bf2eec to 8e4373b Compare April 12, 2024 06:55
@ruzniaievdm ruzniaievdm force-pushed the ruzniaievdm/feat/refactoring-xblock-actions branch from 8e4373b to 17e99bb Compare April 12, 2024 07:46
@GlugovGrGlib GlugovGrGlib requested a review from arbrandes April 12, 2024 08:56
@KristinAoki KristinAoki merged commit a9db690 into openedx:master Apr 12, 2024
66 checks passed
@openedx-webhooks
Copy link

@ruzniaievdm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

KyryloKireiev pushed a commit to raccoongang/edx-platform that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants